net/quic/congestion_control/tcp_cubic_sender_base.h - Issue 1814843002: Remove the unused has_retransmittable_data argument from QuicSendAlgorithm::TimeUntilSend. No func…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/congestion_control/tcp_cubic_sender_base.h

Issue 1814843002: Remove the unused has_retransmittable_data argument from QuicSendAlgorithm::TimeUntilSend. No func… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116887287

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/quic/congestion_control/send_algorithm_simulator.cc ('k') | net/quic/congestion_control/tcp_cubic_sender_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/congestion_control/tcp_cubic_sender_base.h

diff --git a/net/quic/congestion_control/tcp_cubic_sender_base.h b/net/quic/congestion_control/tcp_cubic_sender_base.h

index 4e80a0e1042110b5c904f4ebc56e7bbe17ba8a89..d4749e5d923b97bc22f2a6704c9066b378e4b661 100644

--- a/net/quic/congestion_control/tcp_cubic_sender_base.h

+++ b/net/quic/congestion_control/tcp_cubic_sender_base.h

@@ -56,10 +56,8 @@ class NET_EXPORT_PRIVATE TcpCubicSenderBase : public SendAlgorithmInterface {

HasRetransmittableData is_retransmittable) override;

void OnRetransmissionTimeout(bool packets_retransmitted) override;

void OnConnectionMigration() override;

- QuicTime::Delta TimeUntilSend(

- QuicTime now,

- QuicByteCount bytes_in_flight,

- HasRetransmittableData has_retransmittable_data) const override;

+ QuicTime::Delta TimeUntilSend(QuicTime now,

+ QuicByteCount bytes_in_flight) const override;

QuicBandwidth PacingRate() const override;

QuicBandwidth BandwidthEstimate() const override;

QuicTime::Delta RetransmissionDelay() const override;

« no previous file with comments | « net/quic/congestion_control/send_algorithm_simulator.cc ('k') | net/quic/congestion_control/tcp_cubic_sender_base.cc » ('j') | no next file with comments »