net/quic/congestion_control/tcp_cubic_sender_base.cc - Issue 1814843002: Remove the unused has_retransmittable_data argument from QuicSendAlgorithm::TimeUntilSend. No func…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/congestion_control/tcp_cubic_sender_base.cc

Issue 1814843002: Remove the unused has_retransmittable_data argument from QuicSendAlgorithm::TimeUntilSend. No func… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116887287

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/quic/congestion_control/tcp_cubic_sender_base.h ('k') | net/quic/congestion_control/tcp_cubic_sender_bytes_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/congestion_control/tcp_cubic_sender_base.cc

diff --git a/net/quic/congestion_control/tcp_cubic_sender_base.cc b/net/quic/congestion_control/tcp_cubic_sender_base.cc

index 51e9bed1492479166ef1b672e45f4dbbd3381dde..7f9b3cbffead7b2ab5d2d1665e9483edad5b520c 100644

--- a/net/quic/congestion_control/tcp_cubic_sender_base.cc

+++ b/net/quic/congestion_control/tcp_cubic_sender_base.cc

@@ -175,13 +175,7 @@ bool TcpCubicSenderBase::OnPacketSent(

QuicTime::Delta TcpCubicSenderBase::TimeUntilSend(

QuicTime /* now */,

- QuicByteCount bytes_in_flight,

- HasRetransmittableData has_retransmittable_data) const {

- if (has_retransmittable_data == NO_RETRANSMITTABLE_DATA) {

- QUIC_BUG << "TimeUntilSend's has_retransmittable_data argument deprecated.";

- // For TCP we can always send an ACK immediately.

- return QuicTime::Delta::Zero();

- }

+ QuicByteCount bytes_in_flight) const {

if (InRecovery()) {

// PRR is used when in recovery.

return prr_.TimeUntilSend(GetCongestionWindow(), bytes_in_flight,

« no previous file with comments | « net/quic/congestion_control/tcp_cubic_sender_base.h ('k') | net/quic/congestion_control/tcp_cubic_sender_bytes_test.cc » ('j') | no next file with comments »