Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2076)

Unified Diff: base/i18n/rtl.h

Issue 181483008: Don't unescape BiDi control characters in URL components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/escape.cc » ('j') | net/base/escape.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/i18n/rtl.h
diff --git a/base/i18n/rtl.h b/base/i18n/rtl.h
index aa5f6810a9b0a8f38b9870fbc862ec8313ccfa29..9dce5bcaf4ccfa603f2a70c594886553063c0c29 100644
--- a/base/i18n/rtl.h
+++ b/base/i18n/rtl.h
@@ -18,6 +18,7 @@ class FilePath;
namespace i18n {
+const char16 kArabicLetterMark = 0x061C;
const char16 kRightToLeftMark = 0x200F;
const char16 kLeftToRightMark = 0x200E;
const char16 kLeftToRightEmbeddingMark = 0x202A;
@@ -25,6 +26,10 @@ const char16 kRightToLeftEmbeddingMark = 0x202B;
const char16 kPopDirectionalFormatting = 0x202C;
const char16 kLeftToRightOverride = 0x202D;
const char16 kRightToLeftOverride = 0x202E;
+const char16 kLeftToRightIsolate = 0x2066;
+const char16 kRightToLeftIsolate = 0x2067;
+const char16 kFirstStrongIsolate = 0x2068;
+const char16 kPopDirectionalIsolate = 0x2069;
Peter Kasting 2014/02/27 21:37:09 Why are the changes in this file needed?
Anuj 2014/02/27 21:55:35 Not needed. It just seemed like a related thing to
Peter Kasting 2014/02/27 22:08:38 We shouldn't declare constants we don't refer to.
Anuj 2014/02/27 22:24:51 Done.
// Locale.java mirrored this enum TextDirection. Please keep in sync.
enum TextDirection {
« no previous file with comments | « no previous file | net/base/escape.cc » ('j') | net/base/escape.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698