Don't unescape BiDi control characters in URL components

base/i18n/rtl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_I18N_RTL_H_
 #define BASE_I18N_RTL_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/i18n/base_i18n_export.h"
 #include "base/strings/string16.h"
 #include "build/build_config.h"
 
 namespace base {
 
 class FilePath;
 
 namespace i18n {
 
+const char16 kArabicLetterMark = 0x061C;
 const char16 kRightToLeftMark = 0x200F;
 const char16 kLeftToRightMark = 0x200E;
 const char16 kLeftToRightEmbeddingMark = 0x202A;
 const char16 kRightToLeftEmbeddingMark = 0x202B;
 const char16 kPopDirectionalFormatting = 0x202C;
 const char16 kLeftToRightOverride = 0x202D;
 const char16 kRightToLeftOverride = 0x202E;
+const char16 kLeftToRightIsolate = 0x2066;
+const char16 kRightToLeftIsolate = 0x2067;
+const char16 kFirstStrongIsolate = 0x2068;
+const char16 kPopDirectionalIsolate = 0x2069;

[Peter Kasting, 2014/02/27 21:37:09]

Why are the changes in this file needed?

[Anuj, 2014/02/27 21:55:35]

Not needed. It just seemed like a related thing to be updated.

[Peter Kasting, 2014/02/27 22:08:38]

We shouldn't declare constants we don't refer to.  Let's only add something here
if there's a file that references it.  (Similarly, if any of the existing
constants are never used, we should remove them.)

[Anuj, 2014/02/27 22:24:51]

Done.

 
 // Locale.java mirrored this enum TextDirection. Please keep in sync.
 enum TextDirection {
   UNKNOWN_DIRECTION = 0,
   RIGHT_TO_LEFT = 1,
   LEFT_TO_RIGHT = 2,
   TEXT_DIRECTION_NUM_DIRECTIONS = 3,
 };
 
 // Get the locale that the currently running process has been configured to use.
@@ skipping 102 matching lines @@
 // return the text itself. Explicit bidi control characters display and have
 // semantic effect. They can be deleted so they might not always appear in a
 // pair.
 BASE_I18N_EXPORT string16 StripWrappingBidiControlCharacters(
     const string16& text) WARN_UNUSED_RESULT;
 
 }  // namespace i18n
 }  // namespace base
 
 #endif  // BASE_I18N_RTL_H_