Telemetry: Clean up tap and click_element gestures.

Telemetry: Clean up tap and click_element gestures.

The tap and click_element page actions have a very similar purpose but use a very
different implementation. This patch renames click_element to javascript_click
to indicate that it is not using synthetic gestures as tap does. It also replaces
click_element with tap inside smoothness measurements, so we exercise the entire
input stack. In other places we keep click_element (now javascript_click) because
tap's functionality isn't always sufficient (click elements outside of the view;
clicking on very small elements causes Chrome to magnify the element first).
Further, tap now supports all ways to select an element that click_element
supported (by text, xpath etc).

This CL also removes the tap_element page action, which was only used inside
smoothness for the pica page set. This case is currently broken and adamk@ said
he'd re-implement it using synthetic gestures if needed.

BUG=339233
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255355

[Dominik Grewe, 2014-02-26 14:15:16]

PTAL.

[nduca, 2014-03-05 23:44:43]

lgtm

[Dominik Grewe, 2014-03-06 09:54:27]

The CQ bit was checked by dominikg@chromium.org

[commit-bot: I haz the power, 2014-03-06 09:54:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominikg@chromium.org/181483002/20001

[commit-bot: I haz the power, 2014-03-06 09:54:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 09:54:43]

Failed to apply patch for tools/perf/page_sets/key_silk_cases.json:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/perf/page_sets/key_silk_cases.json
  Hunk #1 FAILED at 105.
  Hunk #2 succeeded at 159 (offset -42 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
tools/perf/page_sets/key_silk_cases.json.rej

Patch:       tools/perf/page_sets/key_silk_cases.json
Index: tools/perf/page_sets/key_silk_cases.json
diff --git a/tools/perf/page_sets/key_silk_cases.json
b/tools/perf/page_sets/key_silk_cases.json
index
e714d77c95f29209f1cda12c2c806c4665c48325..969df7032bcc9543d8f930af061da778f6564a8d
100644
--- a/tools/perf/page_sets/key_silk_cases.json
+++ b/tools/perf/page_sets/key_silk_cases.json
@@ -105,10 +105,10 @@
       },
       "toggle": [
         {
-          "action": "click_element",
-          "selector": ".details-info .play-button:not(.selected)"
-        },
-        { "action": "wait", "seconds": 2}
+          "action": "tap",
+          "selector": ".details-info .play-button:not(.selected)",
+          "wait_after": { "seconds": 2 }
+        }
       ]
     },
     {
@@ -201,10 +201,10 @@
       },
       "toggle_drawer": [
         {
-          "action": "click_element",
-          "selector": "#menu-button"
-        },
-        { "action": "wait", "seconds": 1 }
+          "action": "tap",
+          "selector": "#menu-button",
+          "wait_after": { "seconds": 1 }
+        }
       ]
     },
     {

[Dominik Grewe, 2014-03-06 10:00:17]

The CQ bit was checked by dominikg@chromium.org

[commit-bot: I haz the power, 2014-03-06 10:00:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominikg@chromium.org/181483002/40001

[commit-bot: I haz the power, 2014-03-06 10:57:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 10:57:30]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Dominik Grewe, 2014-03-06 11:45:59]

The CQ bit was checked by dominikg@chromium.org

[commit-bot: I haz the power, 2014-03-06 11:46:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dominikg@chromium.org/181483002/40001

[commit-bot: I haz the power, 2014-03-06 15:15:34]

Change committed as 255355