tools/telemetry/telemetry/page/actions/javascript_click.py - Issue 181483002: Telemetry: Clean up tap and click_element gestures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/actions/javascript_click.py

Issue 181483002: Telemetry: Clean up tap and click_element gestures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/actions/javascript_click.py

diff --git a/tools/telemetry/telemetry/page/actions/click_element.py b/tools/telemetry/telemetry/page/actions/javascript_click.py

similarity index 97%

rename from tools/telemetry/telemetry/page/actions/click_element.py

rename to tools/telemetry/telemetry/page/actions/javascript_click.py

index 91339c76fd375589ade8665ef956356ac2471342..6daaf4f99eda796c3f52c476ba7ae5de147e0ec4 100644

--- a/tools/telemetry/telemetry/page/actions/click_element.py

+++ b/tools/telemetry/telemetry/page/actions/javascript_click.py

@@ -46,6 +46,6 @@ class ClickElementAction(page_action.PageAction):

'Cannot find element with xpath ' + self.xpath)

else:

raise page_action.PageActionFailed(

- 'No condition given to click_element')

+ 'No condition given to javascript_click')

DoClick()