ES6: instanceof error messages need updating.

ES6: instanceof error messages need updating.

We need one message in case the function is not an object, and
another if it was an object but not callable.

R=mstarzinger@chromium.org, rossberg@chromium.org
BUG=

Committed: https://crrev.com/84af5e44266542ff2be5551ec0777ed4a2b7af47
Cr-Commit-Position: refs/heads/master@{#34883}

[mvstanton, 2016-03-17 14:24:20]

Hi Andreas, hi Michael,

ES6 support changed (improved) messages a bit for instanceof. Also, bonus, it
works with ignition. A small parser change was necessary to thread positions
through.
Thanks!
--Mike

[Michael Starzinger, 2016-03-17 14:29:26]

LGTM. Thanks!

[rossberg, 2016-03-17 15:39:31]

lgtm

https://codereview.chromium.org/1814823002/diff/20001/test/message/instanceof...
File test/message/instanceof-nonobject.out (right):

https://codereview.chromium.org/1814823002/diff/20001/test/message/instanceof...
test/message/instanceof-nonobject.out:4: TypeError: Expecting an object in
instanceof check
Nit: maybe it would be even clearer if this message talked about the left-hand
side (in analogy to the other one).

[mvstanton, 2016-03-17 21:20:17]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-03-17 21:20:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1814823002/#ps40001
(title: "Comment response.")

[commit-bot: I haz the power, 2016-03-17 21:20:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814823002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814823002/40001

[mvstanton, 2016-03-17 21:20:50]

Thanks Andreas!
--Mike

https://codereview.chromium.org/1814823002/diff/20001/test/message/instanceof...
File test/message/instanceof-nonobject.out (right):

https://codereview.chromium.org/1814823002/diff/20001/test/message/instanceof...
test/message/instanceof-nonobject.out:4: TypeError: Expecting an object in
instanceof check
On 2016/03/17 15:39:31, rossberg wrote:
> Nit: maybe it would be even clearer if this message talked about the left-hand
> side (in analogy to the other one).

Oh hell yes, thanks! And it's the right hand side we are throwing up about. All
the more reason to mention right-hand side. Updated.

[commit-bot: I haz the power, 2016-03-17 21:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 21:35:42]

Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[mvstanton, 2016-03-18 10:10:38]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-03-18 10:10:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1814823002/#ps60001
(title: "Fixed messages.js")

[commit-bot: I haz the power, 2016-03-18 10:10:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814823002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814823002/60001

[commit-bot: I haz the power, 2016-03-18 10:39:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-18 10:39:34]

Description was changed from

==========
ES6: instanceof error messages need updating.

We need one message in case the function is not an object, and
another if it was an object but not callable.

R=mstarzinger@chromium.org, rossberg@chromium.org
BUG=
==========

to

==========
ES6: instanceof error messages need updating.

We need one message in case the function is not an object, and
another if it was an object but not callable.

R=mstarzinger@chromium.org, rossberg@chromium.org
BUG=

Committed: https://crrev.com/84af5e44266542ff2be5551ec0777ed4a2b7af47
Cr-Commit-Position: refs/heads/master@{#34883}
==========

[commit-bot: I haz the power, 2016-03-18 10:39:35]

Patchset 4 (id:??) landed as
https://crrev.com/84af5e44266542ff2be5551ec0777ed4a2b7af47
Cr-Commit-Position: refs/heads/master@{#34883}