test/message/instanceof-nonobject.out - Issue 1814823002: ES6: instanceof error messages need updating.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/message/instanceof-nonobject.out

Issue 1814823002: ES6: instanceof error messages need updating. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Added new message tests. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 *%(basename)s:30: TypeError: Expecting an object in instanceof check

	2 1 instanceof 2;

	3 ^

	4 TypeError: Expecting an object in instanceof check
	rossberg 2016/03/17 15:39:31 Nit: maybe it would be even clearer if this messag Nit: maybe it would be even clearer if this message talked about the left-hand side (in analogy to the other one). mvstanton 2016/03/17 21:20:50 Oh hell yes, thanks! And it's the right hand side Show quoted text On 2016/03/17 15:39:31, rossberg wrote: > Nit: maybe it would be even clearer if this message talked about the left-hand > side (in analogy to the other one). Oh hell yes, thanks! And it's the right hand side we are throwing up about. All the more reason to mention right-hand side. Updated.
	5 at *%(basename)s:30:3

OLD	NEW

« no previous file with comments | « test/message/instanceof-nonobject.js ('k') | test/message/message.status » ('j') | no next file with comments »