Use unspilled frames in unary operations.

Use unspilled frames in unary operations.

Committed: http://code.google.com/p/v8/source/detail?r=1107

[William Hesse, 2009-01-16 14:39:45]

Passes all tests, fixes a bug in VirtualFrame::PrepareForCall.

[William Hesse, 2009-01-16 14:46:54]

On 2009/01/16 14:39:45, William Hesse wrote:
> Passes all tests, fixes a bug in VirtualFrame::PrepareForCall.

Oops - fails a test.  I have somehow messed up  // 'typeof <expression> ==
<string>'. in BinaryOperation.  I changed LoadTypeOfExpression to return an
unspilled frame, which caused changes there.  The test that fails is
regress-98901.js.  I will fix it, and upload a new version.

[Kevin Millikin (Chromium), 2009-01-17 07:37:59]

If you mean the Mozilla js1_5/Regress/regress-98901.js test, then that is a
separate and known issue.

[Kevin Millikin (Chromium), 2009-01-20 09:55:03]

I have a few comments.

http://codereview.chromium.org/18148/diff/8/203
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/18148/diff/8/203#newcode3634
Line 3634: false_target(), true_target(), true);
Fix indentation.

http://codereview.chromium.org/18148/diff/8/203#newcode3662
Line 3662: // eax: context
Remove this comment.

http://codereview.chromium.org/18148/diff/8/203#newcode3679
Line 3679: frame_->SetElementAt(0, &temp);
I would introduce a version of SetElementAt that took a handle and use it here. 
It seems clumsy to have to explicitly construct a result.

http://codereview.chromium.org/18148/diff/8/203#newcode3724
Line 3724: __ not_(answer.reg());
Do we know that it's safe to destroy answer here?

http://codereview.chromium.org/18148/diff/8/203#newcode3733
Line 3733: frame_->SetElementAt(0,&temp);
Missing space after comma.  Use version of SetElementAt that takes a handle if
you introduce it.

http://codereview.chromium.org/18148/diff/8/201
File src/virtual-frame-ia32.cc (right):

http://codereview.chromium.org/18148/diff/8/201#newcode253
Line 253: // Below the stack pointer, spill all registers and make sure that
This comment needs to be updated.

http://codereview.chromium.org/18148/diff/8/201#newcode897
Line 897: InvokeFlag flag,
Indentation seems off.

http://codereview.chromium.org/18148/diff/8/202
File src/virtual-frame-ia32.h (right):

http://codereview.chromium.org/18148/diff/8/202#newcode345
Line 345: InvokeFlag flag,
Indentation seems off.

[William Hesse, 2009-01-20 11:54:23]

http://codereview.chromium.org/18148/diff/8/203
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/18148/diff/8/203#newcode3634
Line 3634: false_target(), true_target(), true);
On 2009/01/20 09:55:03, Kevin Millikin wrote:
> Fix indentation.

Done.

http://codereview.chromium.org/18148/diff/8/203#newcode3662
Line 3662: // eax: context
On 2009/01/20 09:55:03, Kevin Millikin wrote:
> Remove this comment.

Done.

http://codereview.chromium.org/18148/diff/8/203#newcode3679
Line 3679: frame_->SetElementAt(0, &temp);
On 2009/01/20 09:55:03, Kevin Millikin wrote:
> I would introduce a version of SetElementAt that took a handle and use it
here. 
> It seems clumsy to have to explicitly construct a result.

Done.

http://codereview.chromium.org/18148/diff/8/203#newcode3724
Line 3724: __ not_(answer.reg());
On 2009/01/20 09:55:03, Kevin Millikin wrote:
> Do we know that it's safe to destroy answer here?
No, we don't.

Done.

http://codereview.chromium.org/18148/diff/8/203#newcode3733
Line 3733: frame_->SetElementAt(0,&temp);
On 2009/01/20 09:55:03, Kevin Millikin wrote:
> Missing space after comma.  Use version of SetElementAt that takes a handle if
> you introduce it.

Done.

http://codereview.chromium.org/18148/diff/8/201
File src/virtual-frame-ia32.cc (right):

http://codereview.chromium.org/18148/diff/8/201#newcode253
Line 253: // Below the stack pointer, spill all registers and make sure that
On 2009/01/20 09:55:03, Kevin Millikin wrote:
> This comment needs to be updated.

Done.

http://codereview.chromium.org/18148/diff/8/201#newcode897
Line 897: InvokeFlag flag,
On 2009/01/20 09:55:03, Kevin Millikin wrote:
> Indentation seems off.

Done.

http://codereview.chromium.org/18148/diff/8/202
File src/virtual-frame-ia32.h (right):

http://codereview.chromium.org/18148/diff/8/202#newcode345
Line 345: InvokeFlag flag,
On 2009/01/20 09:55:03, Kevin Millikin wrote:
> Indentation seems off.

Done.

[Kevin Millikin (Chromium), 2009-01-20 11:59:48]

LGTM.