Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org, piman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/97aa5e3544f15ec76416eae93a149dc250c4a647
Cr-Commit-Position: refs/heads/master@{#381647}

[danakj, 2016-03-16 21:47:19]

Description was changed from

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org
BUG=584497
==========

to

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-16 21:51:19]

Description was changed from

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-16 21:51:20]

danakj@chromium.org changed reviewers:
+ piman@chromium.org

[danakj, 2016-03-16 21:51:35]

Description was changed from

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org, piman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-16 21:52:05]

I think I did this without sending or creating anything new in the actual
command buffer. I hope I did it right \noideadog.

[danakj, 2016-03-16 22:00:24]

danakj@chromium.org changed reviewers:
+ sky@chromium.org

[danakj, 2016-03-16 22:00:25]

TBR=sky for mojo/public (we should add owners under mojo/public/c/gles2?)

[danakj, 2016-03-16 22:00:39]

Description was changed from

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org, piman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org, piman
TBR=sky
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[sky, 2016-03-16 22:07:11]

LGTM - more owners for said directories SGTM

[danakj, 2016-03-16 22:09:53]

Description was changed from

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org, piman
TBR=sky
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org, piman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[piman, 2016-03-16 22:53:47]

LGTM, I think I'm ok with that. It's only used by WebGL, so it could move to
there, but I foresee drama, so let's do it here and pay the cost on non-webgl
context, I think it's in the noise.

https://codereview.chromium.org/1814573002/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/gles2_implementation.cc (right):

https://codereview.chromium.org/1814573002/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/gles2_implementation.cc:79: uint32_t
GenerateNextFlushId() {
Should we use StaticAtomicSequenceNumber instead?

[danakj, 2016-03-16 22:58:06]

On 2016/03/16 22:53:47, piman wrote:
> LGTM, I think I'm ok with that. It's only used by WebGL, so it could move to
> there, but I foresee drama, so let's do it here and pay the cost on non-webgl
> context, I think it's in the noise.
> 
>
https://codereview.chromium.org/1814573002/diff/20001/gpu/command_buffer/clie...
> File gpu/command_buffer/client/gles2_implementation.cc (right):
> 
>
https://codereview.chromium.org/1814573002/diff/20001/gpu/command_buffer/clie...
> gpu/command_buffer/client/gles2_implementation.cc:79: uint32_t
> GenerateNextFlushId() {
> Should we use StaticAtomicSequenceNumber instead?

Ill send another CL. CQ green bots are precious.

[danakj, 2016-03-16 22:58:10]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-03-16 22:58:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814573002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814573002/20001

[danakj, 2016-03-17 00:13:43]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-17 00:13:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1814573002/#ps40001
(title: "lastflush: rebase")

[commit-bot: I haz the power, 2016-03-17 00:14:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814573002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814573002/40001

[commit-bot: I haz the power, 2016-03-17 02:41:32]

Description was changed from

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org, piman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org, piman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-03-17 02:41:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-17 02:43:02]

Description was changed from

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org, piman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move flush id from WebGraphicsContext3DImpl to GLES2Implementation.

This means calls to any flush or finish methods on GLES2Implementation
will update the flush id, and calls to either
WebGraphicsContext3D::lastFlushID() or to
GLES2Interface::GetLastFlushIdCHROMIUM() will return the same answer
always.

R=kbr@chromium.org, piman
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/97aa5e3544f15ec76416eae93a149dc250c4a647
Cr-Commit-Position: refs/heads/master@{#381647}
==========

[commit-bot: I haz the power, 2016-03-17 02:43:03]

Patchset 3 (id:??) landed as
https://crrev.com/97aa5e3544f15ec76416eae93a149dc250c4a647
Cr-Commit-Position: refs/heads/master@{#381647}