Use base::AtomicSequenceNumber for the flush id in GLES2Implementation

Use base::AtomicSequenceNumber for the flush id in GLES2Implementation

Instead of writing it ourselves. Note that StaticAtomicSequenceNumber
does not work here since it can only be used in global scope.

R=piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/24f45917406c747d032edf189b3686e4353fb347
Cr-Commit-Position: refs/heads/master@{#381769}

[danakj, 2016-03-16 23:05:38]

Description was changed from

==========
Use base::AtomicSequenceNumber for the flush id in GLES2Implementation

Instead of writing it ourselves. Note that StaticAtomicSequenceNumber
does not work here since it can only be used in global scope.

R=piman@chromium.org
BUG=584497
==========

to

==========
Use base::AtomicSequenceNumber for the flush id in GLES2Implementation

Instead of writing it ourselves. Note that StaticAtomicSequenceNumber
does not work here since it can only be used in global scope.

R=piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-03-16 23:05:49]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 23:06:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809753003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809753003/1

[piman, 2016-03-16 23:49:30]

https://codereview.chromium.org/1809753003/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/gles2_implementation.cc (right):

https://codereview.chromium.org/1809753003/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/gles2_implementation.cc:81: static
base::AtomicSequenceNumber flush_id;
I was thinking, move this out of the function and as a
StaticAtomicSequenceNumber, to avoid the constructor/destructor

[danakj, 2016-03-16 23:50:41]

https://codereview.chromium.org/1809753003/diff/20001/gpu/command_buffer/clie...
File gpu/command_buffer/client/gles2_implementation.cc (right):

https://codereview.chromium.org/1809753003/diff/20001/gpu/command_buffer/clie...
gpu/command_buffer/client/gles2_implementation.cc:81: static
base::AtomicSequenceNumber flush_id;
On 2016/03/16 23:49:29, piman wrote:
> I was thinking, move this out of the function and as a
> StaticAtomicSequenceNumber, to avoid the constructor/destructor

Oh, snap. Sure :)

[danakj, 2016-03-17 00:54:50]

PTAL

[piman, 2016-03-17 01:31:16]

lgtm

[danakj, 2016-03-17 17:54:29]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-03-17 17:54:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809753003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809753003/40001

[commit-bot: I haz the power, 2016-03-17 19:15:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-17 19:16:47]

Description was changed from

==========
Use base::AtomicSequenceNumber for the flush id in GLES2Implementation

Instead of writing it ourselves. Note that StaticAtomicSequenceNumber
does not work here since it can only be used in global scope.

R=piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Use base::AtomicSequenceNumber for the flush id in GLES2Implementation

Instead of writing it ourselves. Note that StaticAtomicSequenceNumber
does not work here since it can only be used in global scope.

R=piman@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/24f45917406c747d032edf189b3686e4353fb347
Cr-Commit-Position: refs/heads/master@{#381769}
==========

[commit-bot: I haz the power, 2016-03-17 19:16:48]

Patchset 3 (id:??) landed as
https://crrev.com/24f45917406c747d032edf189b3686e4353fb347
Cr-Commit-Position: refs/heads/master@{#381769}