wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.

Committed: https://crrev.com/1465f844b54478a027711e86011a19214d8de24d
Cr-Commit-Position: refs/heads/master@{#382773}

Committed: https://crrev.com/18c4dc63362c6d136985f8a6d260318d9a3c0104
Cr-Commit-Position: refs/heads/master@{#382912}

[Bret, 2016-03-16 21:56:52]

Description was changed from

==========
wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.
==========

to

==========
wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.
==========

[Bret, 2016-03-16 21:56:52]

bsep@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-03-17 07:59:25]

haraken@chromium.org changed reviewers:
+ yutak@chromium.org

[haraken, 2016-03-17 07:59:26]

LGTM, but yutak@ might want to confirm this.

[Yuta Kitamura, 2016-03-17 08:19:08]

I think this is OK. I'm slightly concerned on the performance
difference, but that's something hard to foresee, so I'm
leaning towards "just land it and see".

Introducing "DoSomething" style naming convention to Blink
seems a little bit early, but writing an adapter just to
fix the naming isn't worthwhile given that the Great
Reformatting is expected to happen relatively soon.

LGTM if my comment is addressed.

https://codereview.chromium.org/1814563002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/CheckedNumeric.h (right):

https://codereview.chromium.org/1814563002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/CheckedNumeric.h:36: 
We usually add "using WTF::CheckedNumeric" in the global
namespace, too, so the user code doesn't have to put "WTF::".

[dcheng, 2016-03-17 08:25:14]

drive by

https://codereview.chromium.org/1814563002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/StdLibExtras.h (right):

https://codereview.chromium.org/1814563002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/StdLibExtras.h:157: return checked.ValueOrDie();
checked_cast is the //base/numerics/safe_conversions.h equivalent.

[Bret, 2016-03-18 20:48:51]

https://codereview.chromium.org/1814563002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/CheckedNumeric.h (right):

https://codereview.chromium.org/1814563002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/CheckedNumeric.h:36: 
On 2016/03/17 08:19:08, Yuta Kitamura wrote:
> We usually add "using WTF::CheckedNumeric" in the global
> namespace, too, so the user code doesn't have to put "WTF::".

Done.

https://codereview.chromium.org/1814563002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/StdLibExtras.h (right):

https://codereview.chromium.org/1814563002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/StdLibExtras.h:157: return checked.ValueOrDie();
On 2016/03/17 08:25:14, dcheng wrote:
> checked_cast is the //base/numerics/safe_conversions.h equivalent.

Done.

[Bret, 2016-03-18 20:48:57]

The CQ bit was checked by bsep@chromium.org

[Bret, 2016-03-18 20:48:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/1814563002/#ps20001
(title: "no wtf::")

[commit-bot: I haz the power, 2016-03-18 20:49:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814563002/20001

[commit-bot: I haz the power, 2016-03-18 20:52:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 20:52:33]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bret, 2016-03-18 23:18:17]

The CQ bit was checked by bsep@chromium.org

[Bret, 2016-03-18 23:18:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/1814563002/#ps40001
(title: "fix merge conflict")

[commit-bot: I haz the power, 2016-03-18 23:19:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814563002/40001

[commit-bot: I haz the power, 2016-03-19 01:03:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 01:03:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bret, 2016-03-22 23:26:00]

On 2016/03/19 01:03:28, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

FYI a few tests were crashing due to my change in ImageResource.cpp since it
couldn't coerce a negative delta into an unsigned size_t, so I rewrote it to be
more careful about the conversions.

[Bret, 2016-03-22 23:26:09]

The CQ bit was checked by bsep@chromium.org

[Bret, 2016-03-22 23:26:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/1814563002/#ps60001
(title: "more careful about size_t math in ImageResource")

[commit-bot: I haz the power, 2016-03-22 23:26:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814563002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814563002/60001

[commit-bot: I haz the power, 2016-03-23 02:27:24]

Description was changed from

==========
wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.
==========

to

==========
wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.
==========

[commit-bot: I haz the power, 2016-03-23 02:27:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-23 02:28:39]

Description was changed from

==========
wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.
==========

to

==========
wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.

Committed: https://crrev.com/1465f844b54478a027711e86011a19214d8de24d
Cr-Commit-Position: refs/heads/master@{#382773}
==========

[commit-bot: I haz the power, 2016-03-23 02:28:42]

Patchset 4 (id:??) landed as
https://crrev.com/1465f844b54478a027711e86011a19214d8de24d
Cr-Commit-Position: refs/heads/master@{#382773}

[aberent, 2016-03-23 16:12:20]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1822353002/ by aberent@chromium.org.

The reason for reverting is: Chrome crashes in power.typical_10_mobile test on
various Android bots.

BUG=597268.

[Bret, 2016-03-23 17:22:15]

Description was changed from

==========
wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.

Committed: https://crrev.com/1465f844b54478a027711e86011a19214d8de24d
Cr-Commit-Position: refs/heads/master@{#382773}
==========

to

==========
wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.

Committed: https://crrev.com/1465f844b54478a027711e86011a19214d8de24d
Cr-Commit-Position: refs/heads/master@{#382773}
==========

[Bret, 2016-03-23 17:43:02]

On 2016/03/23 16:12:20, aberent wrote:
> A revert of this CL (patchset #4 id:60001) has been created in
> https://codereview.chromium.org/1822353002/ by mailto:aberent@chromium.org.
> 
> The reason for reverting is: Chrome crashes in power.typical_10_mobile test on
> various Android bots.
> 
> BUG=597268.

Since apparently adding a crash for an underflow is problematic I'm going to
revert it for now and spin it out into a separate patch.

[Bret, 2016-03-23 17:43:11]

The CQ bit was checked by bsep@chromium.org

[Bret, 2016-03-23 17:43:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yutak@chromium.org
Link to the patchset: https://codereview.chromium.org/1814563002/#ps80001
(title: "revert new check")

[commit-bot: I haz the power, 2016-03-23 17:43:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814563002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814563002/80001

[commit-bot: I haz the power, 2016-03-23 20:24:15]

Description was changed from

==========
wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.

Committed: https://crrev.com/1465f844b54478a027711e86011a19214d8de24d
Cr-Commit-Position: refs/heads/master@{#382773}
==========

to

==========
wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.

Committed: https://crrev.com/1465f844b54478a027711e86011a19214d8de24d
Cr-Commit-Position: refs/heads/master@{#382773}
==========

[commit-bot: I haz the power, 2016-03-23 20:24:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-23 20:25:11]

Description was changed from

==========
wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.

Committed: https://crrev.com/1465f844b54478a027711e86011a19214d8de24d
Cr-Commit-Position: refs/heads/master@{#382773}
==========

to

==========
wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.

Committed: https://crrev.com/1465f844b54478a027711e86011a19214d8de24d
Cr-Commit-Position: refs/heads/master@{#382773}

Committed: https://crrev.com/18c4dc63362c6d136985f8a6d260318d9a3c0104
Cr-Commit-Position: refs/heads/master@{#382912}
==========

[commit-bot: I haz the power, 2016-03-23 20:25:14]

Patchset 5 (id:??) landed as
https://crrev.com/18c4dc63362c6d136985f8a6d260318d9a3c0104
Cr-Commit-Position: refs/heads/master@{#382912}