third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp - Issue 1814563002: wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

Issue 1814563002: wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert new check Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp ('k') | third_party/WebKit/Source/wtf/CheckedArithmetic.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

index ca5aa844875e91636a01b3f645440ce75788fc16..bf683cfad7d6c9e8bada84a670b31e97d816ecfb 100644

--- a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

+++ b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

@@ -43,6 +43,7 @@

#include "public/platform/WebGraphicsContext3D.h"

#include "public/platform/WebGraphicsContext3DProvider.h"

#include "wtf/ArrayBufferContents.h"

+#include "wtf/CheckedNumeric.h"

#include <algorithm>

#ifndef NDEBUG

#include "wtf/RefCountedLeakCounter.h"

@@ -870,10 +871,10 @@ bool DrawingBuffer::paintRenderingResultsToImageData(int& width, int& height, So

width = size().width();

height = size().height();

- Checked<int, RecordOverflow> dataSize = 4;

+ CheckedNumeric<int> dataSize = 4;

dataSize *= width;

dataSize *= height;

- if (dataSize.hasOverflowed())

+ if (!dataSize.IsValid())

return false;

WTF::ArrayBufferContents pixels(width * height, 4, WTF::ArrayBufferContents::NotShared, WTF::ArrayBufferContents::DontInitialize);