Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Unified Diff: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h

Issue 1814513002: Fix sizing issues in the tab modal signin flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address message handler related feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h
diff --git a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h
index b36c3d93efde785b11fb7e61482c5589a24aa3b0..1b607d5a7658323844d02c060e66bc719c3525ef 100644
--- a/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h
+++ b/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h
@@ -35,7 +35,8 @@ class SigninViewControllerDelegateViews : public views::DialogDelegateView,
SigninViewControllerDelegateViews(
SigninViewController* signin_view_controller,
views::WebView* content_view,
- Browser* browser);
+ Browser* browser,
+ bool wait_for_size);
sky 2016/04/04 15:04:02 Document what wait_For_size means.
anthonyvd 2016/04/04 20:35:24 Done.
// Creates the web view that contains the signin flow in |mode| using
// |profile| as the web content's profile, then sets |delegate| as the created
@@ -59,11 +60,16 @@ class SigninViewControllerDelegateViews : public views::DialogDelegateView,
private:
void PerformClose() override;
+ void ResizeNativeView(int height) override;
+
+ void DisplayModal();
~SigninViewControllerDelegateViews() override;
views::WebView* content_view_;
views::Widget* modal_signin_widget_; // Not owned.
+ bool wait_for_size_;
+ Browser* browser_;
DISALLOW_COPY_AND_ASSIGN(SigninViewControllerDelegateViews);
};

Powered by Google App Engine
This is Rietveld 408576698