Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h

Issue 1814513002: Fix sizing issues in the tab modal signin flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address message handler related feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_DELEGATE_VIEWS_H _ 5 #ifndef CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_DELEGATE_VIEWS_H _
6 #define CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_DELEGATE_VIEWS_H _ 6 #define CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_DELEGATE_VIEWS_H _
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/ui/profile_chooser_constants.h" 9 #include "chrome/browser/ui/profile_chooser_constants.h"
10 #include "chrome/browser/ui/signin_view_controller_delegate.h" 10 #include "chrome/browser/ui/signin_view_controller_delegate.h"
(...skipping 17 matching lines...) Expand all
28 // Views implementation of SigninViewControllerDelegate. It's responsible for 28 // Views implementation of SigninViewControllerDelegate. It's responsible for
29 // managing the Signin and Sync Confirmation tab-modal dialogs. 29 // managing the Signin and Sync Confirmation tab-modal dialogs.
30 // Instances of this class delete themselves when the window they're managing 30 // Instances of this class delete themselves when the window they're managing
31 // closes (in the DeleteDelegate callback). 31 // closes (in the DeleteDelegate callback).
32 class SigninViewControllerDelegateViews : public views::DialogDelegateView, 32 class SigninViewControllerDelegateViews : public views::DialogDelegateView,
33 public SigninViewControllerDelegate { 33 public SigninViewControllerDelegate {
34 public: 34 public:
35 SigninViewControllerDelegateViews( 35 SigninViewControllerDelegateViews(
36 SigninViewController* signin_view_controller, 36 SigninViewController* signin_view_controller,
37 views::WebView* content_view, 37 views::WebView* content_view,
38 Browser* browser); 38 Browser* browser,
39 bool wait_for_size);
sky 2016/04/04 15:04:02 Document what wait_For_size means.
anthonyvd 2016/04/04 20:35:24 Done.
39 40
40 // Creates the web view that contains the signin flow in |mode| using 41 // Creates the web view that contains the signin flow in |mode| using
41 // |profile| as the web content's profile, then sets |delegate| as the created 42 // |profile| as the web content's profile, then sets |delegate| as the created
42 // web content's delegate. 43 // web content's delegate.
43 static views::WebView* CreateGaiaWebView( 44 static views::WebView* CreateGaiaWebView(
44 content::WebContentsDelegate* delegate, 45 content::WebContentsDelegate* delegate,
45 profiles::BubbleViewMode mode, 46 profiles::BubbleViewMode mode,
46 Profile* profile, 47 Profile* profile,
47 signin_metrics::AccessPoint access_point); 48 signin_metrics::AccessPoint access_point);
48 49
49 static views::WebView* CreateSyncConfirmationWebView(Profile* profile); 50 static views::WebView* CreateSyncConfirmationWebView(Profile* profile);
50 51
51 // views::DialogDelegateView: 52 // views::DialogDelegateView:
52 views::View* GetContentsView() override; 53 views::View* GetContentsView() override;
53 views::Widget* GetWidget() override; 54 views::Widget* GetWidget() override;
54 const views::Widget* GetWidget() const override; 55 const views::Widget* GetWidget() const override;
55 void DeleteDelegate() override; 56 void DeleteDelegate() override;
56 ui::ModalType GetModalType() const override; 57 ui::ModalType GetModalType() const override;
57 bool ShouldShowCloseButton() const override; 58 bool ShouldShowCloseButton() const override;
58 int GetDialogButtons() const override; 59 int GetDialogButtons() const override;
59 60
60 private: 61 private:
61 void PerformClose() override; 62 void PerformClose() override;
63 void ResizeNativeView(int height) override;
64
65 void DisplayModal();
62 66
63 ~SigninViewControllerDelegateViews() override; 67 ~SigninViewControllerDelegateViews() override;
64 68
65 views::WebView* content_view_; 69 views::WebView* content_view_;
66 views::Widget* modal_signin_widget_; // Not owned. 70 views::Widget* modal_signin_widget_; // Not owned.
71 bool wait_for_size_;
72 Browser* browser_;
67 73
68 DISALLOW_COPY_AND_ASSIGN(SigninViewControllerDelegateViews); 74 DISALLOW_COPY_AND_ASSIGN(SigninViewControllerDelegateViews);
69 }; 75 };
70 76
71 #endif // CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_DELEGATE_VIEW S_H_ 77 #endif // CHROME_BROWSER_UI_VIEWS_PROFILES_SIGNIN_VIEW_CONTROLLER_DELEGATE_VIEW S_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698