Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h

Issue 1814513002: Fix sizing issues in the tab modal signin flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address message handler related feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
diff --git a/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h b/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
index b1e9c1291b8a8403aa7ea6bbb21ec70f1255e912..b723fd0bde14364b693f854e36c920b9b0be8450 100644
--- a/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
+++ b/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
@@ -36,7 +36,8 @@ class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
SigninViewControllerDelegateMac(SigninViewController* signin_view_controller,
scoped_ptr<content::WebContents> web_contents,
content::WebContents* host_web_contents,
- NSRect frame);
+ NSRect frame,
+ bool wait_for_size);
static
SigninViewControllerDelegateMac* CreateModalSigninDelegateWithNavigation(
@@ -61,6 +62,9 @@ class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
private:
void PerformClose() override;
+ void ResizeNativeView(int height) override;
+
+ void DisplayModal();
~SigninViewControllerDelegateMac() override;
@@ -68,6 +72,10 @@ class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
scoped_ptr<content::WebContents> web_contents_;
base::scoped_nsobject<ConstrainedWindowCustomWindow> window_;
+ bool wait_for_size_;
Robert Sesek 2016/04/04 14:54:34 Can you document what these variables are? It's no
anthonyvd 2016/04/04 20:35:24 Done.
+ content::WebContents* host_web_contents_;
+ NSRect window_frame_;
+
DISALLOW_COPY_AND_ASSIGN(SigninViewControllerDelegateMac);
};

Powered by Google App Engine
This is Rietveld 408576698