Fix sizing issues in the tab modal signin flow.

chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_PROFILES_SIGNIN_VIEW_CONTROLLER_DELEGATE_MAC_H_
 #define CHROME_BROWSER_UI_COCOA_PROFILES_SIGNIN_VIEW_CONTROLLER_DELEGATE_MAC_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/mac/scoped_nsobject.h"
@@ skipping 18 matching lines @@
 // Cocoa implementation of SigninViewControllerDelegate. It's responsible for
 // managing the Signin and Sync Confirmation tab-modal dialogs.
 // Instances of this class delete themselves when the window they manage is
 // closed (in the OnConstrainedWindowClosed callback).
 class SigninViewControllerDelegateMac : public ConstrainedWindowMacDelegate,
                                         public SigninViewControllerDelegate {
  public:
   SigninViewControllerDelegateMac(SigninViewController* signin_view_controller,
                                   scoped_ptr<content::WebContents> web_contents,
                                   content::WebContents* host_web_contents,
-                                  NSRect frame);
+                                  NSRect frame,
+                                  bool wait_for_size);
 
   static
   SigninViewControllerDelegateMac* CreateModalSigninDelegateWithNavigation(
       SigninViewController* signin_view_controller,
       scoped_ptr<content::WebContents> web_contents,
       content::WebContents* host_web_contents,
       NSRect frame);
 
   void OnConstrainedWindowClosed(ConstrainedWindowMac* window) override;
 
   // Creates the web view that contains the signin flow in |mode| using
   // |profile| as the web content's profile, then sets |delegate| as the created
   // web content's delegate.
   static scoped_ptr<content::WebContents> CreateGaiaWebContents(
       content::WebContentsDelegate* delegate,
       profiles::BubbleViewMode mode,
       Profile* profile,
       signin_metrics::AccessPoint access_point);
 
   static scoped_ptr<content::WebContents> CreateSyncConfirmationWebContents(
       Profile* profile);
 
  private:
   void PerformClose() override;
+  void ResizeNativeView(int height) override;
+
+  void DisplayModal();
 
   ~SigninViewControllerDelegateMac() override;
 
   scoped_ptr<ConstrainedWindowMac> constrained_window_;
   scoped_ptr<content::WebContents> web_contents_;
   base::scoped_nsobject<ConstrainedWindowCustomWindow> window_;
 
+  bool wait_for_size_;

[Robert Sesek, 2016/04/04 14:54:34]

Can you document what these variables are? It's not immediately clear what
wait_for_size_ means and how it affects the other state in this class.

Some of that commentary should also move up to the ctor comment or class comment
so users of this class know what to pass for wait_for_size.

[anthonyvd, 2016/04/04 20:35:24]

Done.

+  content::WebContents* host_web_contents_;
+  NSRect window_frame_;
+
   DISALLOW_COPY_AND_ASSIGN(SigninViewControllerDelegateMac);
 };
 
 #endif  // CHROME_BROWSER_UI_COCOA_PROFILES_SIGNIN_VIEW_CONTROLLER_DELEGATE_MAC_H_