third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp - Issue 1814263004: Remove create/delete methods from WebGraphicsContext3D.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp

Issue 1814263004: Remove create/delete methods from WebGraphicsContext3D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@complex-casts

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webgl/CHROMIUMValuebuffer.cpp ('K') | « third_party/WebKit/Source/modules/webgl/CHROMIUMValuebuffer.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp » ('j') | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp b/third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp

index a3144eef04e46b0887324fd6df119b8c47b3f7e9..fd4202a843206eaf9047e21c4f9cbd6310847b38 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLBuffer.cpp

@@ -25,6 +25,7 @@

#include "modules/webgl/WebGLBuffer.h"

+#include "gpu/command_buffer/client/gles2_interface.h"

#include "modules/webgl/WebGLRenderingContextBase.h"

namespace blink {

@@ -39,7 +40,9 @@ WebGLBuffer::WebGLBuffer(WebGLRenderingContextBase* ctx)

, m_initialTarget(0)

, m_size(0)

{

- setObject(ctx->webContext()->createBuffer());

+ uint32_t buffer;

+ ctx->contextGL()->GenBuffers(1, &buffer);

+ setObject(buffer);

}

WebGLBuffer::~WebGLBuffer()

@@ -50,7 +53,7 @@ WebGLBuffer::~WebGLBuffer()

void WebGLBuffer::deleteObjectImpl(WebGraphicsContext3D* context3d, gpu::gles2::GLES2Interface* gl)

{

- context3d->deleteBuffer(m_object);

+ gl->DeleteBuffers(1, &m_object);

m_object = 0;

}