third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h - Issue 1814263004: Remove create/delete methods from WebGraphicsContext3D.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

Issue 1814263004: Remove create/delete methods from WebGraphicsContext3D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@complex-casts

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webgl/CHROMIUMValuebuffer.cpp ('K') | « third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

index 7899c9a328dc747b9638f8f47ade5d838deab7f9..356c6da54be1fb8ca8e2e4647e05ce170094a07c 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h

@@ -64,7 +64,7 @@ public:

static WebGLFramebuffer* create(WebGLRenderingContextBase*);

- Platform3DObject object() const { return m_object; }

+ uint32_t object() const { return m_object; }

Ken Russell (switch to Gerrit) 2016/03/19 01:46:39 Here and for m_object it would be semantically hel

danakj 2016/03/21 22:27:02 Done.

void setAttachmentForBoundFramebuffer(GLenum target, GLenum attachment, GLenum texTarget, WebGLTexture*, GLint level, GLint layer);

void setAttachmentForBoundFramebuffer(GLenum target, GLenum attachment, WebGLRenderbuffer*);

@@ -114,7 +114,7 @@ private:

// Check if a new drawBuffers call should be issued. This is called when we add or remove an attachment.

void drawBuffersIfNecessary(bool force);

- Platform3DObject m_object;

+ uint32_t m_object;

typedef HeapHashMap<GLenum, Member<WebGLAttachment>> AttachmentMap;