Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 1813843002: Revert of free -> reset (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
Reviewers:
mtklein, mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of free -> reset (patchset #3 id:40001 of https://codereview.chromium.org/1811723002/ ) Reason for revert: Suspect for Win10 failures. Original issue's description: > free -> reset > > The C++ standard library uses ".reset()" where we sometimes write ".free()". > We also use ".reset()" quite a lot. This standardizes on ".reset()". > > This is one more step towards dropping SkAutoTDelete in favor of the standard > std::unique_ptr. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1811723002 > > Committed: https://skia.googlesource.com/skia/+/0e3738db89e86035ed5d4f629bf58b817b1e5274 TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/43812e24cbb97208d149f419f0c3f61181ba4126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -21 lines) Patch
M bench/GrMemoryPoolBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTypes.h View 3 chunks +9 lines, -2 lines 0 comments Download
M include/private/SkTemplates.h View 4 chunks +12 lines, -2 lines 0 comments Download
M src/codec/SkBmpCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkJpegCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkRawCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGlyph.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrBatchFontCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/SkBitSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/xml/SkDOM.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
bungeman-skia
Created Revert of free -> reset
4 years, 9 months ago (2016-03-17 16:53:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813843002/1
4 years, 9 months ago (2016-03-17 16:53:52 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 16:54:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/43812e24cbb97208d149f419f0c3f61181ba4126

Powered by Google App Engine
This is Rietveld 408576698