Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1811723002: free -> reset (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

free -> reset The C++ standard library uses ".reset()" where we sometimes write ".free()". We also use ".reset()" quite a lot. This standardizes on ".reset()". This is one more step towards dropping SkAutoTDelete in favor of the standard std::unique_ptr. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1811723002 Committed: https://skia.googlesource.com/skia/+/0e3738db89e86035ed5d4f629bf58b817b1e5274 Committed: https://skia.googlesource.com/skia/+/852f15da7ceb53cfb49b9f728baa6dbc53b27694

Patch Set 1 #

Patch Set 2 : odd #

Patch Set 3 : zarro boogs found #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -39 lines) Patch
M bench/GrMemoryPoolBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTypes.h View 3 chunks +2 lines, -9 lines 0 comments Download
M include/private/SkTemplates.h View 1 2 4 chunks +2 lines, -12 lines 0 comments Download
M src/codec/SkBmpCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkJpegCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkRawCodec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGlyph.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrBatchFontCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/SkBitSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/xml/SkDOM.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811723002/1
4 years, 9 months ago (2016-03-16 21:08:44 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/1200) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
4 years, 9 months ago (2016-03-16 21:10:55 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811723002/20001
4 years, 9 months ago (2016-03-16 21:17:45 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811723002/40001
4 years, 9 months ago (2016-03-16 21:30:25 UTC) #9
mtklein_C
Similar but less interesting than the last detach -> release CL. Getting close.
4 years, 9 months ago (2016-03-17 00:15:58 UTC) #12
reed1
lgtm
4 years, 9 months ago (2016-03-17 01:57:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811723002/40001
4 years, 9 months ago (2016-03-17 12:32:44 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/0e3738db89e86035ed5d4f629bf58b817b1e5274
4 years, 9 months ago (2016-03-17 12:36:21 UTC) #17
bungeman-skia
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1813843002/ by bungeman@google.com. ...
4 years, 9 months ago (2016-03-17 16:53:47 UTC) #18
mtklein
gonna tick this to reland when the tree opens
4 years, 9 months ago (2016-03-17 17:16:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811723002/40001
4 years, 9 months ago (2016-03-17 17:16:39 UTC) #22
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 17:51:30 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/852f15da7ceb53cfb49b9f728baa6dbc53b27694

Powered by Google App Engine
This is Rietveld 408576698