third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html - Issue 1813823002: Handle the case where the v8 scriptable object has a property defined with value undefined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html

Issue 1813823002: Handle the case where the v8 scriptable object has a property defined with value undefined. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use shouldBeTrue in layout test and defines testGetUndefined in blink_deprecated_test_plugin.cc Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/tests/blink_deprecated_test_plugin.cc ('k') | third_party/WebKit/LayoutTests/plugins/plugin-scriptable-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html

diff --git a/third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html b/third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html

new file mode 100644

index 0000000000000000000000000000000000000000..9567a1b7d496c82c75fec067feefb47360cfd20f

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html

@@ -0,0 +1,28 @@

+<html>

+<head>

+<script src="../resources/js-test.js"></script>

+<script>

+description("This tests checks that hasOwnProperty return true on plugin's getters that return undefined");

+jsTestIsAsync = true;

bashi 2016/03/22 23:14:50 Why does this test need to be async?

+var ref;

+function onLoad() {

+ // The plugin implements testGetUndefined the same way as the following:

+ function ReferenceObject () {

+ Object.defineProperties(this, {

+ "testGetUndefined": { get: function () { return undefined; } }

+ });

+ }

+ ref = new ReferenceObject();

+ shouldBeTrue('ref.hasOwnProperty("testGetUndefined")');

+ shouldBeTrue('document.getElementById("plugin").hasOwnProperty("testGetUndefined")');

+ finishJSTest();

+</script>

+</head>

+<body onload="onLoad()">

+<object id="plugin" type="application/x-blink-deprecated-test-plugin"></object>

+</body>

+</html>