third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html - Issue 1813823002: Handle the case where the v8 scriptable object has a property defined with value undefined.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html

Issue 1813823002: Handle the case where the v8 scriptable object has a property defined with value undefined. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use shouldBeTrue in layout test and defines testGetUndefined in blink_deprecated_test_plugin.cc Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../resources/js-test.js"></script>

	4 <script>

	5 description("This tests checks that hasOwnProperty return true on plugin's gette rs that return undefined");

	6 jsTestIsAsync = true;
	bashi 2016/03/22 23:14:50 Why does this test need to be async? Why does this test need to be async?
	7 var ref;

	8

	9 function onLoad() {

	10 // The plugin implements testGetUndefined the same way as the following:

	11 function ReferenceObject () {

	12 Object.defineProperties(this, {

	13 "testGetUndefined": { get: function () { return undefined; } }

	14 });

	15 }

	16 ref = new ReferenceObject();

	17

	18 shouldBeTrue('ref.hasOwnProperty("testGetUndefined")');

	19 shouldBeTrue('document.getElementById("plugin").hasOwnProperty("testGetUndef ined")');

	20

	21 finishJSTest();

	22 }

	23 </script>

	24 </head>

	25 <body onload="onLoad()">

	26 <object id="plugin" type="application/x-blink-deprecated-test-plugin"></object>

	27 </body>

	28 </html>

OLD	NEW