third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html - Issue 1813823002: Handle the case where the v8 scriptable object has a property defined with value undefined.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/plugins/plugin-scriptable.html

Issue 1813823002: Handle the case where the v8 scriptable object has a property defined with value undefined. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script>

	4 if (!window.testRunner) {

	5 document.write("This test does not work in manual mode.");

	6 } else {

	7 testRunner.dumpAsText()

	8 testRunner.waitUntilDone();

	9 }

	10

	11 function onLoad() {

	12 var plugin = document.getElementById("test");

	13 plugin.setAttribute("type", "application/x-blink-deprecated-test-plugin");

	14

	15 function TestObject () {

	16 Object.defineProperties(this, {

	17 "testprop": { get: function () { return undefined; } }
	dcheng 2016/03/21 17:29:21 If you rebase, can you just use testObject instead If you rebase, can you just use testObject instead of testprop? Julien Isorce Samsung 2016/03/21 18:02:56 Do you mean renaming "testprop" to "testObject" ev Show quoted text On 2016/03/21 17:29:21, dcheng wrote: > If you rebase, can you just use testObject instead of testprop? Do you mean renaming "testprop" to "testObject" everywhere ? (in this file and in the pepper plugin) dcheng 2016/03/21 18:09:15 https://codereview.chromium.org/1814093003 recentl Show quoted text On 2016/03/21 at 18:02:56, j.isorce wrote: > On 2016/03/21 17:29:21, dcheng wrote: > > If you rebase, can you just use testObject instead of testprop? > > Do you mean renaming "testprop" to "testObject" everywhere ? (in this file and in the pepper plugin) https://codereview.chromium.org/1814093003 recently landed, so the deprecated test plugin already has a property (testObject) that I think you can just reuse for this test.
	18 });

	19 }

	20

	21 var ref = new TestObject;

	22

	23 if (ref.hasOwnProperty("testprop") === plugin.hasOwnProperty("testprop") == true)

	24 document.getElementById('result').innerHTML = 'SUCCESS';

	25

	26 testRunner.notifyDone();

	27 }

	28 </script>

	29 </head>

	30 <body onload="onLoad()">

	31 <div>This tests checks that hasOwnProperty return true on plugin's getters that return undefined</div>

	32 <object id="test" type="application/x-blink-deprecated-test-plugin"></object>

	33 <div id="result">FAILURE</div>

	34 </body>

	35 </html>

OLD	NEW