LayoutTests: migrate nested-plugin-objects to ppapi

LayoutTests: migrate nested-plugin-objects to ppapi

This found a couple of bugs on the way.

BUG=474535
Committed: https://crrev.com/1379dae4ebb397bd8ef008c44a3f23e7369545f2
Cr-Commit-Position: refs/heads/master@{#382247}

[piman, 2016-03-18 04:35:16]

piman@chromium.org changed reviewers:
+ dcheng@chromium.org, raymes@chromium.org

[piman, 2016-03-18 04:35:17]

dcheng: please review
raymes: ppapi/ OWNER

[dcheng, 2016-03-18 07:08:09]

https://codereview.chromium.org/1814093003/diff/1/ppapi/tests/blink_deprecate...
File ppapi/tests/blink_deprecated_test_plugin.cc (right):

https://codereview.chromium.org/1814093003/diff/1/ppapi/tests/blink_deprecate...
ppapi/tests/blink_deprecated_test_plugin.cc:72: accessor->second.Run(true,
const_cast<pp::Var*>(&value));
Heh

https://codereview.chromium.org/1814093003/diff/1/ppapi/tests/blink_deprecate...
ppapi/tests/blink_deprecated_test_plugin.cc:191: void LogDestroyAccessor(bool
set, pp::Var* var) {
Maybe we don't need this? We're unconditionally logging this at plugin teardown.

https://codereview.chromium.org/1814093003/diff/1/ppapi/tests/blink_deprecate...
ppapi/tests/blink_deprecated_test_plugin.cc:203: test_object_var_ =
pp::VarPrivate(instance_, test_object_.get());
Some comments seemed to imply that pp::VarPrivate ends up taking ownership of
test_object_. Should it still be saved in a scoped_ptr?

[piman, 2016-03-18 18:41:13]

https://codereview.chromium.org/1814093003/diff/1/ppapi/tests/blink_deprecate...
File ppapi/tests/blink_deprecated_test_plugin.cc (right):

https://codereview.chromium.org/1814093003/diff/1/ppapi/tests/blink_deprecate...
ppapi/tests/blink_deprecated_test_plugin.cc:191: void LogDestroyAccessor(bool
set, pp::Var* var) {
On 2016/03/18 07:08:09, dcheng wrote:
> Maybe we don't need this? We're unconditionally logging this at plugin
teardown.

You're right... the NPAPI one did this conditionally, but that seems needlessly
complicated. We can just rebaseline as needed.

https://codereview.chromium.org/1814093003/diff/1/ppapi/tests/blink_deprecate...
ppapi/tests/blink_deprecated_test_plugin.cc:203: test_object_var_ =
pp::VarPrivate(instance_, test_object_.get());
On 2016/03/18 07:08:09, dcheng wrote:
> Some comments seemed to imply that pp::VarPrivate ends up taking ownership of
> test_object_. Should it still be saved in a scoped_ptr?

You're absolutely right. Fixed.

[dcheng, 2016-03-18 21:11:12]

lgtm

[piman, 2016-03-18 21:23:15]

The CQ bit was checked by piman@chromium.org

[commit-bot: I haz the power, 2016-03-18 21:23:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814093003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814093003/40001

[commit-bot: I haz the power, 2016-03-18 21:41:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 21:41:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[raymes, 2016-03-20 22:37:44]

lgtm - let me know if one of you want to go onto ppapi/OWNERS for this type of
thing :)

[dcheng, 2016-03-21 04:17:21]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-03-21 04:17:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814093003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814093003/40001

[commit-bot: I haz the power, 2016-03-21 08:01:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-21 08:02:49]

Description was changed from

==========
LayoutTests: migrate nested-plugin-objects to ppapi

This found a couple of bugs on the way.

BUG=474535
==========

to

==========
LayoutTests: migrate nested-plugin-objects to ppapi

This found a couple of bugs on the way.

BUG=474535

Committed: https://crrev.com/1379dae4ebb397bd8ef008c44a3f23e7369545f2
Cr-Commit-Position: refs/heads/master@{#382247}
==========

[commit-bot: I haz the power, 2016-03-21 08:02:50]

Patchset 3 (id:??) landed as
https://crrev.com/1379dae4ebb397bd8ef008c44a3f23e7369545f2
Cr-Commit-Position: refs/heads/master@{#382247}