Link chrome_elf.dll instead of statically linking the blacklist code

Link chrome_elf.dll instead of statically linking the blacklist code

This ensure that the dll code is referenced, instead of the target
making its own copy.

TBR=sky@chromium.org
BUG=329023
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253847

[csharp, 2014-02-26 16:44:25]

Patch 1 is the original change I committed yesterday.
Patch 2 is the new version using a new static library chrome_elf_constants
instead of exporting constants in the dll.

[robertshield, 2014-02-26 19:42:51]

https://codereview.chromium.org/181373003/diff/20001/chrome/browser/DEPS
File chrome/browser/DEPS (right):

https://codereview.chromium.org/181373003/diff/20001/chrome/browser/DEPS#newc...
chrome/browser/DEPS:6: "+chrome_elf",
I would feel better if we could add an include_rule that could only pull in the
constants (I think they can be done per-file).

[csharp, 2014-02-26 20:42:30]

tbr'ing sky@ for chrome/renderer/chrome_content_renderer_client.cc approval
since it wasn't changed since last commit attempt

https://codereview.chromium.org/181373003/diff/20001/chrome/browser/DEPS
File chrome/browser/DEPS (right):

https://codereview.chromium.org/181373003/diff/20001/chrome/browser/DEPS#newc...
chrome/browser/DEPS:6: "+chrome_elf",
On 2014/02/26 19:42:51, robertshield wrote:
> I would feel better if we could add an include_rule that could only pull in
the
> constants (I think they can be done per-file).

Done.

[csharp, 2014-02-26 20:42:34]

The CQ bit was checked by csharp@chromium.org

[commit-bot: I haz the power, 2014-02-26 20:45:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/181373003/20001

[commit-bot: I haz the power, 2014-02-26 22:20:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-26 22:20:48]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests,
check_deps, check_deps2git, chrome_elf_unittests, chromedriver_unittests,
components_unittests, compositor_unittests, content_browsertests,
content_unittests, crypto_unittests, events_unittests, google_apis_unittests,
gpu_unittests, installer_util_unittests, ipc_tests, jingle_unittests,
media_unittests, mini_installer_test, nacl_integration, ppapi_unittests,
printing_unittests, remoting_unittests, sql_unittests, sync_integration_tests,
sync_unit_tests, telemetry_perf_unittests, telemetry_unittests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[robertshield, 2014-02-27 01:11:43]

On 2014/02/26 22:20:48, I haz the power (commit-bot) wrote:
> Retried try job too often on win_rel for step(s) app_list_unittests,
> ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests,
> check_deps, check_deps2git, chrome_elf_unittests, chromedriver_unittests,
> components_unittests, compositor_unittests, content_browsertests,
> content_unittests, crypto_unittests, events_unittests, google_apis_unittests,
> gpu_unittests, installer_util_unittests, ipc_tests, jingle_unittests,
> media_unittests, mini_installer_test, nacl_integration, ppapi_unittests,
> printing_unittests, remoting_unittests, sql_unittests, sync_integration_tests,
> sync_unit_tests, telemetry_perf_unittests, telemetry_unittests,
views_unittests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Looks like the test targets need to link the constants lib as well.

[csharp, 2014-02-27 14:01:26]

On 2014/02/27 01:11:43, robertshield wrote:
> On 2014/02/26 22:20:48, I haz the power (commit-bot) wrote:
> > Retried try job too often on win_rel for step(s) app_list_unittests,
> > ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests,
> > check_deps, check_deps2git, chrome_elf_unittests, chromedriver_unittests,
> > components_unittests, compositor_unittests, content_browsertests,
> > content_unittests, crypto_unittests, events_unittests,
google_apis_unittests,
> > gpu_unittests, installer_util_unittests, ipc_tests, jingle_unittests,
> > media_unittests, mini_installer_test, nacl_integration, ppapi_unittests,
> > printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests,
> > sync_unit_tests, telemetry_perf_unittests, telemetry_unittests,
> views_unittests
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
> 
> Looks like the test targets need to link the constants lib as well.

They alright did (via chrome_elf_lib->chrome_elf_common->chrome_elf_constants),
I just hadn't added the header file to the test file.

[csharp, 2014-02-27 14:01:54]

The CQ bit was checked by csharp@chromium.org

[commit-bot: I haz the power, 2014-02-27 14:02:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/181373003/40001

[robertshield, 2014-02-27 14:54:31]

lgtm

[commit-bot: I haz the power, 2014-02-27 17:15:08]

Change committed as 253847