chrome_elf/chrome_elf.gyp - Issue 181373003: Link chrome_elf.dll instead of statically linking the blacklist code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/chrome_elf.gyp

Issue 181373003: Link chrome_elf.dll instead of statically linking the blacklist code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Add header Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_elf/chrome_elf.gyp

diff --git a/chrome_elf/chrome_elf.gyp b/chrome_elf/chrome_elf.gyp

index fa6ed36f773d4903c83fd091132e94b88170b0fc..5820fc277457d30f07dd5b8cc412c58d1b73a509 100644

--- a/chrome_elf/chrome_elf.gyp

+++ b/chrome_elf/chrome_elf.gyp

@@ -126,7 +126,7 @@

{

- 'target_name': 'chrome_elf_common',

+ 'target_name': 'chrome_elf_constants',

'type': 'static_library',

'include_dirs': [

'..',

@@ -134,6 +134,27 @@

'sources': [

'chrome_elf_constants.cc',

'chrome_elf_constants.h',

+ ],

+ 'conditions': [

+ ['component=="shared_library"', {

+ # In component builds, all targets depend on chrome_redirects by

+ # default. Remove it here so we are able to test it.

+ 'dependencies!': [

+ '../chrome_elf/chrome_elf.gyp:chrome_redirects',

+ ],

+ }],

+ ],

+ },

+ {

+ 'target_name': 'chrome_elf_common',

+ 'type': 'static_library',

+ 'dependencies': [

+ 'chrome_elf_constants',

+ ],

+ 'include_dirs': [

+ '..',

+ ],

+ 'sources': [

'chrome_elf_types.h',

'chrome_elf_util.cc',

'chrome_elf_util.h',

« no previous file with comments | « chrome_elf/blacklist/test/blacklist_test.cc ('k') | chrome_elf/chrome_elf_constants.h » ('j') | no next file with comments »