Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1813623002: Prevent the "Stop using an invalid certificate" button from showing up on about:blank for OSX. (Closed)

Created:
4 years, 9 months ago by lgarron
Modified:
4 years, 9 months ago
Reviewers:
palmer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent the "Stop using an invalid certificate" button from showing up on about:blank for OSX. BUG=595512, 558581 TEST=Visit about:blank, click on the page icon several times, and make sure that the "Stop using an invalid certificate" never appears. Committed: https://crrev.com/99889dad84e0e17e216336a1255173c70d6776bf Cr-Commit-Position: refs/heads/master@{#382107}

Patch Set 1 : #

Patch Set 2 : Update test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
lgarron
palmer@, could you review?
4 years, 9 months ago (2016-03-17 01:08:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813623002/20001
4 years, 9 months ago (2016-03-17 05:43:32 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/196534)
4 years, 9 months ago (2016-03-17 06:40:30 UTC) #10
lgarron
palmer@: pingo mcbingo!
4 years, 9 months ago (2016-03-18 20:07:05 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813623002/40001
4 years, 9 months ago (2016-03-18 20:07:11 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 20:56:59 UTC) #15
palmer
lgtm
4 years, 9 months ago (2016-03-18 22:03:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813623002/40001
4 years, 9 months ago (2016-03-18 22:04:00 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-18 22:09:51 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 22:11:49 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99889dad84e0e17e216336a1255173c70d6776bf
Cr-Commit-Position: refs/heads/master@{#382107}

Powered by Google App Engine
This is Rietveld 408576698