chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm - Issue 1813623002: Prevent the "Stop using an invalid certificate" button from showing up on about:blank for OSX.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

Issue 1813623002: Prevent the "Stop using an invalid certificate" button from showing up on about:blank for OSX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update test. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

index 1a4dad158c18db01279cbda842a4218b348b5f4a..b9c93daa4f16f29a7c37d3c71581c5d98d89f9b0 100644

--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

@@ -649,7 +649,7 @@ NSPoint AnchorPointForWindow(NSWindow* parent) {

certificateId_ = identityInfo.cert_id;

- if (identityInfo.show_ssl_decision_revoke_button) {

+ if (certificateId_ && identityInfo.show_ssl_decision_revoke_button) {

NSString* text = l10n_util::GetNSString(

IDS_PAGEINFO_RESET_INVALID_CERTIFICATE_DECISIONS_BUTTON);

resetDecisionsButton_ =

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm » ('j') | no next file with comments »