third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.h - Issue 1813383002: Move all fast-path paint invalidation mapping into PaintInvalidationState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.h

Issue 1813383002: Move all fast-path paint invalidation mapping into PaintInvalidationState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reorganize conditions in PaintInvalidationState constructor Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.h ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.h

index 2d851b1a90a00e2b7d45aa275aa3604ccf2587f3..24209fc52d55b11912a996442ed4682be1dbe5a0 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.h

@@ -44,14 +44,17 @@ public:

FloatRect strokeBoundingBox() const final;

FloatRect paintInvalidationRectInLocalSVGCoordinates() const final;

- LayoutRect clippedOverflowRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidationState* = nullptr) const final;

- void mapLocalToAncestor(const LayoutBoxModelObject* ancestor, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = nullptr, const PaintInvalidationState* = nullptr) const final;

+ LayoutRect absoluteClippedOverflowRect() const final;

+ void mapLocalToAncestor(const LayoutBoxModelObject* ancestor, TransformState&, MapCoordinatesFlags = ApplyContainerFlip, bool* wasFixed = nullptr) const final;

const LayoutObject* pushMappingToContainer(const LayoutBoxModelObject* ancestorToStopAt, LayoutGeometryMap&) const final;

void absoluteQuads(Vector<FloatQuad>&, bool* wasFixed) const final;

private:

InlineFlowBox* createInlineFlowBox() final;

+ // This method should never be called. Should use paintInvalidationRectInLocalSVGCoordinates().

+ using LayoutObject::localOverflowRectForPaintInvalidation;

void invalidateTreeIfNeeded(const PaintInvalidationState&) final;

void willBeDestroyed() final;