third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h - Issue 1813383002: Move all fast-path paint invalidation mapping into PaintInvalidationState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h

Issue 1813383002: Move all fast-path paint invalidation mapping into PaintInvalidationState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reorganize conditions in PaintInvalidationState constructor Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp ('K') | « third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp » ('j') | third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h

index b8ea64ae55c6162243ef7e9951f9db9fe07e066a..7e2fe28db1c25cb6e934b76ea4073751ab9169cd 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h

@@ -60,7 +60,11 @@ private:

IntRect linesBoundingBox() const override;

InlineTextBox* createTextBox(int start, unsigned short length) override;

- LayoutRect clippedOverflowRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer, const PaintInvalidationState*) const final;

+ LayoutRect absoluteClippedOverflowRect() const final;

+ FloatRect paintInvalidationRectInLocalSVGCoordinates() const final;

+ // This method should never be called. Should use paintInvalidationRectInLocalSVGCoordinates().

+ using LayoutObject::localOverflowRectForPaintInvalidation;

pdr. 2016/03/23 22:50:07 What does this "using" statement do?

Xianzhu 2016/03/23 23:52:34 It makes the method private not needing to redefin

float m_scalingFactor;

Font m_scaledFont;