Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1813233002: Make Win runtime DLLs writeable before overwriting (Closed)

Created:
4 years, 9 months ago by borenet2
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make Win runtime DLLs writeable before overwriting This should fix the VS2015 bot which is failing because we can't overwrite read-only DLL files. BUG=skia:4553 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1813233002 Committed: https://skia.googlesource.com/skia/+/1195260e22fc2e9c92b435491d4d19108a20df5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M gyp_skia View 5 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
borenet
4 years, 9 months ago (2016-03-18 15:09:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813233002/1
4 years, 9 months ago (2016-03-18 15:09:36 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 15:18:07 UTC) #7
bungeman-skia
lgtm
4 years, 9 months ago (2016-03-18 15:32:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813233002/1
4 years, 9 months ago (2016-03-18 15:32:46 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 15:33:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1195260e22fc2e9c92b435491d4d19108a20df5c

Powered by Google App Engine
This is Rietveld 408576698