Make Win runtime DLLs writeable before overwriting

gyp_skia

 #!/usr/bin/env python
 
 # Copyright 2011 The Android Open Source Project
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This script is a wrapper which invokes gyp with the correct --depth argument,
 # and supports the automatic regeneration of build files if all.gyp is
 # changed (Linux-only).
 
 import glob
 import os
 import platform
 import shlex
+import stat
 import sys
 
 script_dir = os.path.abspath(os.path.dirname(__file__))
 
 # Directory within which we can find the gyp source.
 gyp_source_dir = os.path.join(script_dir, 'third_party', 'externals', 'gyp')
 
 # Directory within which we can find most of Skia's gyp configuration files.
 gyp_config_dir = os.path.join(script_dir, 'gyp')
 
@@ skipping 57 matching lines @@
     elif sys.platform.startswith('win'):
       default_gyp_generators = 'ninja,msvs-ninja'
     elif sys.platform.startswith('cygwin'):
       default_gyp_generators = 'ninja,msvs-ninja'
     else:
       default_gyp_generators = 'ninja'
     os.environ[ENVVAR_GYP_GENERATORS] = default_gyp_generators
     print ('%s environment variable not set, using default, %s' %
            (ENVVAR_GYP_GENERATORS, default_gyp_generators))
 
-  vs2013_runtime_dll_dirs = None
+  vs_runtime_dll_dirs = None
   if os.getenv('CHROME_HEADLESS', '0') == '1':
     if sys.platform.startswith('win') or sys.platform.startswith('cygwin'):
       chrome_path = os.getenv('CHROME_PATH')
       os.chdir(chrome_path)
       sys.path.append(os.path.join(chrome_path, 'build'))
       sys.path.append(os.path.join(chrome_path, 'tools'))
       import vs_toolchain
-      vs2013_runtime_dll_dirs = \
+      vs_runtime_dll_dirs = \
           vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
 
   # Set CWD to the directory containing this script.
   # This allows us to launch it from other directories, in spite of gyp's
   # finickyness about the current working directory.
   # See http://b.corp.google.com/issue?id=5019517 ('Linux make build
   # (from out dir) no longer runs skia_gyp correctly')
   os.chdir(os.path.abspath(script_dir))
 
   # This could give false positives since it doesn't actually do real option
   # parsing.  Oh well.
   gyp_file_specified = False
   for arg in args:
     if arg.endswith('.gyp'):
       gyp_file_specified = True
       break
 
   # If we didn't get a file, then fall back to assuming 'skia.gyp' from the
   # same directory as the script.
   # The gypfile must be passed as a relative path, not an absolute path,
   # or else the gyp code doesn't write into the proper output dir.
   if not gyp_file_specified:
     args.append('skia.gyp')
 
   args.extend(['-I' + i for i in additional_include_files(args)])
   args.extend(['--depth', '.'])
 
   # Tell gyp to write the build files into output_dir.
-  args.extend(['--generator-output', os.path.abspath(get_output_dir())])
+  out_dir = os.path.abspath(get_output_dir())
+  args.extend(['--generator-output', out_dir])
 
   # Tell ninja to write its output into the same directory.
   args.extend(['-Goutput_dir=%s' % gyp_output_dir])
 
   # By default, we build 'most' instead of 'all' or 'everything'. See skia.gyp.
   args.extend(['-Gdefault_target=most'])
 
   # Fail if any files specified in the project are missing
   if sys.platform.startswith('win'):
     gyp_generator_flags = os.getenv(ENVVAR_GYP_GENERATOR_FLAGS, '')
@@ skipping 10 matching lines @@
     args.remove('--dry-run')
     print gyp_source_dir, ' '.join(args)
   else:
     # Off we go...
     res = gyp.main(args)
     if res:
       sys.exit(res)
 
   # This code is copied from Chrome's build/gyp_chromium. It's not clear why
   # the *_runtime variables are reversed.
-  if vs2013_runtime_dll_dirs:
-    x64_runtime, x86_runtime = vs2013_runtime_dll_dirs
+  if vs_runtime_dll_dirs:
+    # The DLLs might be read-only, which will cause an error when attempting to
+    # overwrite them. Make them writeable first.
+    for path, dirs, files in os.walk(out_dir):
+      for f in files:
+        if f.endswith('.dll'):
+          os.chmod(os.path.join(path, f), stat.S_IWRITE)
+
+    x64_runtime, x86_runtime = vs_runtime_dll_dirs
     vs_toolchain.CopyVsRuntimeDlls(
-        os.path.join(os.getenv('CHROME_PATH'), get_output_dir()),
+        os.path.join(os.getenv('CHROME_PATH'), out_dir),
         (x86_runtime, x64_runtime))