Show the full extension information in the extension controlled setting bubble

Show the full extension information in the extension controlled setting bubble for Default search engines.

Also fix the glitch where the bubble popping up from the Default Search Engine list (DSE) appearing behind a selected row in the Other Search Engine list (OSE). That is fixed by making the OSE list have a lower z-index within the stacking context than the DSE.

BUG=314507
R=dbeam@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255931

[Dan Beam, 2014-03-07 20:13:02]

lgtm

https://codereview.chromium.org/181293005/diff/20001/chrome/browser/resources...
File chrome/browser/resources/options/search_engine_manager_engine_list.js
(right):

https://codereview.chromium.org/181293005/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/search_engine_manager_engine_list.js:190:
extension: engine.extension};
nit: space before } to stay consistent with other code in this file

[Finnur, 2014-03-10 12:01:10]

Done. Thanks!

[Finnur, 2014-03-10 12:01:40]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2014-03-10 12:01:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/finnur@chromium.org/181293005/40001

[Finnur, 2014-03-10 12:59:20]

Committed patchset #3 manually as r255931 (presubmit successful).

[commit-bot: I haz the power, 2014-03-10 13:02:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/finnur@chromium.org/181293005/40001

[commit-bot: I haz the power, 2014-03-10 13:02:57]

Failed to apply patch for
chrome/browser/resources/options/search_engine_manager_engine_list.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/resources/options/search_engine_manager_engine_list.js
  Hunk #1 FAILED at 186.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/options/search_engine_manager_engine_list.js.rej

Patch:      
chrome/browser/resources/options/search_engine_manager_engine_list.js
Index: chrome/browser/resources/options/search_engine_manager_engine_list.js
diff --git
a/chrome/browser/resources/options/search_engine_manager_engine_list.js
b/chrome/browser/resources/options/search_engine_manager_engine_list.js
index
9bc12b9f8b618b9647d0357e07d7dbc3440c71f0..0be060294d4fd1a262fa3a7f2eac2dff03c9beb8
100644
--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js
+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js
@@ -186,9 +186,8 @@ cr.define('options.search_engines', function() {
         // CoreOptionsHandler::CreateValueForPref() does.
         var event = new Event(this.contentType);
         if (engine.extension) {
-          event.value = { controlledBy: 'extension' };
-          // TODO(mad): add id, name, and icon once we solved the issue with
the
-          // search engine manager in http://crbug.com/314507.
+          event.value = { controlledBy: 'extension',
+                          extension: engine.extension };
         } else {
           event.value = { controlledBy: 'policy' };
         }