Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4150)

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 181293005: Show the full extension information in the extension controlled setting bubble (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add space Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/search_engine_manager.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/search_engine_manager_engine_list.js
diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js
index 9bc12b9f8b618b9647d0357e07d7dbc3440c71f0..0be060294d4fd1a262fa3a7f2eac2dff03c9beb8 100644
--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js
+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js
@@ -186,9 +186,8 @@ cr.define('options.search_engines', function() {
// CoreOptionsHandler::CreateValueForPref() does.
var event = new Event(this.contentType);
if (engine.extension) {
- event.value = { controlledBy: 'extension' };
- // TODO(mad): add id, name, and icon once we solved the issue with the
- // search engine manager in http://crbug.com/314507.
+ event.value = { controlledBy: 'extension',
+ extension: engine.extension };
} else {
event.value = { controlledBy: 'policy' };
}
« no previous file with comments | « chrome/browser/resources/options/search_engine_manager.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698