Rename net::BidirectionalStream*Job to net::BidirectionalStream*Impl

Rename net::BidirectionalStream*Job to net::BidirectionalStream*Impl

This CL renames net::BidirectionalStream*Job to net::BidirectionalStream*Impl.

BUG=584338
Committed: https://crrev.com/5749218caeebdd18bfe53ef5c23273b5960e907f
Cr-Commit-Position: refs/heads/master@{#382588}

[xunjieli, 2016-03-18 19:44:25]

Patchset #1 (id:1) has been deleted

[xunjieli, 2016-03-18 19:46:18]

xunjieli@chromium.org changed reviewers:
+ mef@chromium.org

[xunjieli, 2016-03-18 19:46:19]

PTAL.

[mef, 2016-03-21 22:00:43]

lgtm, I find BidirectionalStreamImpl a little confusing, but I don't think that
BidirectionalStreamBaseImpl is much better, so I'm fine leaving it as is.

https://codereview.chromium.org/1812823010/diff/40001/net/http/bidirectional_...
File net/http/bidirectional_stream.h (right):

https://codereview.chromium.org/1812823010/diff/40001/net/http/bidirectional_...
net/http/bidirectional_stream.h:163: BidirectionalStreamImpl* stream) override;
should this param be called |stream_impl|?

https://codereview.chromium.org/1812823010/diff/40001/net/http/bidirectional_...
net/http/bidirectional_stream.h:198: // The underlying BidirectioanlStreamJob
used for this stream. It is non-NULL,
BidirectionalStreamImpl

https://codereview.chromium.org/1812823010/diff/40001/net/http/bidirectional_...
File net/http/bidirectional_stream_impl.h (right):

https://codereview.chromium.org/1812823010/diff/40001/net/http/bidirectional_...
net/http/bidirectional_stream_impl.h:31: class NET_EXPORT_PRIVATE
BidirectionalStreamImpl {
Maybe call it BidirectionalStreamBaseImpl as this is subclassed by
BidirectionalStreamQuicImpl and BidirectionalStreamSpdyImpl?

[xunjieli, 2016-03-22 15:24:24]

Thanks for the review! I agree that BidirectionalStreamImpl is a pretty
confusing name since the class doesn't have any concrete implementation but it
is called Impl. I am not sure BidirectionalStreamBaseImpl clears up the
confusion, since it has a Impl suffix. We could try changing it to
BidirectionalStreamBase, but it would disconnect this class from
BidirectionalStreamSpdyImpl and BidirectionalStreamQuicImpl, so I am not sure
what is the best action here. I guess i will leave this as it is. Thanks!

https://codereview.chromium.org/1812823010/diff/40001/net/http/bidirectional_...
File net/http/bidirectional_stream.h (right):

https://codereview.chromium.org/1812823010/diff/40001/net/http/bidirectional_...
net/http/bidirectional_stream.h:163: BidirectionalStreamImpl* stream) override;
On 2016/03/21 22:00:43, mef wrote:
> should this param be called |stream_impl|?

Done.

https://codereview.chromium.org/1812823010/diff/40001/net/http/bidirectional_...
net/http/bidirectional_stream.h:198: // The underlying BidirectioanlStreamJob
used for this stream. It is non-NULL,
On 2016/03/21 22:00:43, mef wrote:
> BidirectionalStreamImpl

Done.

[xunjieli, 2016-03-22 15:24:50]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2016-03-22 15:24:51]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org
Link to the patchset: https://codereview.chromium.org/1812823010/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-03-22 15:25:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812823010/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812823010/60001

[commit-bot: I haz the power, 2016-03-22 16:43:15]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-03-22 16:44:36]

Description was changed from

==========
Rename net::BidirectionalStream*Job to net::BidirectionalStream*Impl

This CL renames net::BidirectionalStream*Job to net::BidirectionalStream*Impl.

BUG=584338
==========

to

==========
Rename net::BidirectionalStream*Job to net::BidirectionalStream*Impl

This CL renames net::BidirectionalStream*Job to net::BidirectionalStream*Impl.

BUG=584338

Committed: https://crrev.com/5749218caeebdd18bfe53ef5c23273b5960e907f
Cr-Commit-Position: refs/heads/master@{#382588}
==========

[commit-bot: I haz the power, 2016-03-22 16:44:37]

Patchset 3 (id:??) landed as
https://crrev.com/5749218caeebdd18bfe53ef5c23273b5960e907f
Cr-Commit-Position: refs/heads/master@{#382588}