net/http/http_network_transaction.h - Issue 1812823010: Rename net::BidirectionalStream*Job to net::BidirectionalStream*Impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_transaction.h

Issue 1812823010: Rename net::BidirectionalStream*Job to net::BidirectionalStream*Impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_transaction.h

diff --git a/net/http/http_network_transaction.h b/net/http/http_network_transaction.h

index 5b554afd8e8805ae16a931134ba3d7dd52fbc6d0..43b2863db6704a66315cc7c58a38609b2563f4b4 100644

--- a/net/http/http_network_transaction.h

+++ b/net/http/http_network_transaction.h

@@ -36,7 +36,7 @@ class ECPrivateKey;

namespace net {

-class BidirectionalStreamJob;

+class BidirectionalStreamImpl;

class ClientSocketHandle;

class HttpAuthController;

class HttpNetworkSession;

@@ -97,10 +97,9 @@ class NET_EXPORT_PRIVATE HttpNetworkTransaction

void OnStreamReady(const SSLConfig& used_ssl_config,

const ProxyInfo& used_proxy_info,

HttpStream* stream) override;

- void OnBidirectionalStreamJobReady(

- const SSLConfig& used_ssl_config,

- const ProxyInfo& used_proxy_info,

- BidirectionalStreamJob* stream_job) override;

+ void OnBidirectionalStreamImplReady(const SSLConfig& used_ssl_config,

+ const ProxyInfo& used_proxy_info,

+ BidirectionalStreamImpl* stream) override;

void OnWebSocketHandshakeStreamReady(

const SSLConfig& used_ssl_config,

const ProxyInfo& used_proxy_info,

« no previous file with comments | « net/http/bidirectional_stream_unittest.cc ('k') | net/http/http_network_transaction.cc » ('j') | no next file with comments »