[iOS] Define global assert_no_deps and use it to prevent regressions.

[iOS] Define global assert_no_deps and use it to prevent regressions.

Define a global assert_no_deps on iOS (in ios/build/config.gni) and
use it in targets that have been fixed to work on iOS to prevent
further regression.

BUG=297668
Committed: https://crrev.com/bb3d6abbcdd5471561da7ea8da7740048e4b4a01
Cr-Commit-Position: refs/heads/master@{#382286}

[sdefresne, 2016-03-17 12:09:55]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org

[sdefresne, 2016-03-17 12:09:55]

Please take a look.

This is using the suggestion from https://codereview.chromium.org/1801083002/.

[brettw, 2016-03-18 21:17:50]

LGTM.

Sorry, I did this yesterday but forgot to push send!

https://codereview.chromium.org/1812823002/diff/1/ios/build/config.gni
File ios/build/config.gni (right):

https://codereview.chromium.org/1812823002/diff/1/ios/build/config.gni#newcode7
ios/build/config.gni:7: conceptually_bad_dependencies = [
Can you call this ...ios_dependencies instead (same below)? When you import this
header, this will get into the namespace of the file and it won't be so clear.

Actually, it looks like maybe these aren't necessary outside of this header. If
that's the case, you can keep the names as-is and prefix then with _ to avoid
exporting them to BUILD files that import this.

[sdefresne, 2016-03-21 13:59:38]

Thank you for the review.

https://codereview.chromium.org/1812823002/diff/1/ios/build/config.gni
File ios/build/config.gni (right):

https://codereview.chromium.org/1812823002/diff/1/ios/build/config.gni#newcode7
ios/build/config.gni:7: conceptually_bad_dependencies = [
On 2016/03/18 at 21:17:50, brettw wrote:
> Can you call this ...ios_dependencies instead (same below)? When you import
this header, this will get into the namespace of the file and it won't be so
clear.
> 
> Actually, it looks like maybe these aren't necessary outside of this header.
If that's the case, you can keep the names as-is and prefix then with _ to avoid
exporting them to BUILD files that import this.

Done (both changes).

[sdefresne, 2016-03-21 13:59:57]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-03-21 13:59:57]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1812823002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-03-21 14:00:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812823002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812823002/20001

[commit-bot: I haz the power, 2016-03-21 14:45:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-21 14:46:56]

Description was changed from

==========
[iOS] Define global assert_no_deps and use it to prevent regressions.

Define a global assert_no_deps on iOS (in ios/build/config.gni) and
use it in targets that have been fixed to work on iOS to prevent
further regression.

BUG=297668
==========

to

==========
[iOS] Define global assert_no_deps and use it to prevent regressions.

Define a global assert_no_deps on iOS (in ios/build/config.gni) and
use it in targets that have been fixed to work on iOS to prevent
further regression.

BUG=297668

Committed: https://crrev.com/bb3d6abbcdd5471561da7ea8da7740048e4b4a01
Cr-Commit-Position: refs/heads/master@{#382286}
==========

[commit-bot: I haz the power, 2016-03-21 14:46:57]

Patchset 2 (id:??) landed as
https://crrev.com/bb3d6abbcdd5471561da7ea8da7740048e4b4a01
Cr-Commit-Position: refs/heads/master@{#382286}