ios/build/config.gni - Issue 1812823002: [iOS] Define global assert_no_deps and use it to prevent regressions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/build/config.gni

Issue 1812823002: [iOS] Define global assert_no_deps and use it to prevent regressions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@components-invalidation

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # Global list of dependencies that are conceptually bad on iOS and should

	6 # never be added (they will never be supported).

	7 conceptually_bad_dependencies = [
	brettw 2016/03/18 21:17:50 Can you call this ...ios_dependencies instead (sam Can you call this ...ios_dependencies instead (same below)? When you import this header, this will get into the namespace of the file and it won't be so clear. Actually, it looks like maybe these aren't necessary outside of this header. If that's the case, you can keep the names as-is and prefix then with _ to avoid exporting them to BUILD files that import this. sdefresne 2016/03/21 13:59:38 Done (both changes). Show quoted text On 2016/03/18 at 21:17:50, brettw wrote: > Can you call this ...ios_dependencies instead (same below)? When you import this header, this will get into the namespace of the file and it won't be so clear. > > Actually, it looks like maybe these aren't necessary outside of this header. If that's the case, you can keep the names as-is and prefix then with _ to avoid exporting them to BUILD files that import this. Done (both changes).
	8 "//cc/*",

	9 "//content/*",

	10 "//dbus/*",

	11 "//ipc/*",

	12 "//jingle/*",

	13 "//media/*",

	14 "//third_party/webrtc/*",

	15 "//third_party/WebKit/*",

	16 ]

	17

	18 # Global list of conceptually fine dependencies but currently unsupported

	19 # on iOS. exclusions will be removed when the dependencies are fixed.

	20 transient_bad_dependencies = [ "//mojo/edk/*" ]

	21

	22 ios_assert_no_deps = conceptually_bad_dependencies + transient_bad_dependencies

OLD	NEW

« no previous file with comments | « components/BUILD.gn ('k') | ui/events/BUILD.gn » ('j') | no next file with comments »