src/flag-definitions.h - Issue 1812673005: Use ICU case conversion/transliterator for case conversion behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/flag-definitions.h

Issue 1812673005: Use ICU case conversion/transliterator for case conversion behind a flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: working with icu-case-mapping.js manually compiled in; gyp change not picking it up Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/flag-definitions.h

diff --git a/src/flag-definitions.h b/src/flag-definitions.h

index f887418a2c472b0b7c4c4b0933184ff53203c80d..ee63b681889af95353ef619a3363b1e6d8bb74c4 100644

--- a/src/flag-definitions.h

+++ b/src/flag-definitions.h

@@ -178,6 +178,12 @@ DEFINE_BOOL(experimental_extras, false,

// Flags for language modes and experimental language features.

DEFINE_BOOL(use_strict, false, "enforce strict mode")

+#ifdef V8_I18N_SUPPORT

+DEFINE_BOOL(icu_case_mapping, false,

+ "case mapping with ICU rather than Unibrow")

+DEFINE_NEG_IMPLICATION(es_staging, icu_case_mapping)

jungshik at Google 2016/04/29 06:55:32 I noticed that https://codereview.chromium.org/15

+#endif

DEFINE_BOOL(es_staging, false,

"enable test-worthy harmony features (for internal use only)")

DEFINE_BOOL(harmony, false, "enable all completed harmony features")

« src/bootstrapper.cc ('K') | « src/bootstrapper.cc ('k') | src/js/i18n.js » ('j') | src/js/i18n.js » ('J')