Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1513873002: Unstage non-standard Promise functions (Closed)

Created:
5 years ago by Dan Ehrenberg
Modified:
5 years ago
Reviewers:
rossberg, adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unstage non-standard Promise functions This patch removes Promise functions and methods which are absent from the ES2015 specification when the --es-staging flag is on. The patch is being relanded after being reverted due to an unrelated bug. This version is slightly different as promise_chain is installed on the context regardless of the flag value, so that the Promise::Chain API continues to work until it is deprecated. BUG=v8:3237 R=rossberg LOG=Y Committed: https://crrev.com/88c8361b8fd11566983e6ae071e74770b5c506ad Cr-Commit-Position: refs/heads/master@{#32772}

Patch Set 1 #

Total comments: 1

Patch Set 2 : harmony, not es-staging #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -28 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 5 chunks +6 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/js/prologue.js View 1 chunk +3 lines, -0 lines 0 comments Download
M src/js/promise.js View 3 chunks +10 lines, -3 lines 0 comments Download
A src/js/promise-extra.js View 1 chunk +26 lines, -0 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reentry.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-after-resolve.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-all.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-late.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-uncaught.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-uncaught-all.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-uncaught-uncaught.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-throw-in-reject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-all.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-late.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-uncaught.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-uncaught-all.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-uncaught-uncaught.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/promise-internal-setter.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/es6/promises.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regress/regress-cr372788.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/messages.js View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Dan Ehrenberg
5 years ago (2015-12-09 23:05:59 UTC) #1
adamk
lgtm % es_staging/harmony confusion https://codereview.chromium.org/1513873002/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/1513873002/diff/1/src/flag-definitions.h#newcode194 src/flag-definitions.h:194: DEFINE_NEG_IMPLICATION(es_staging, promise_extra) Confusingly, I think ...
5 years ago (2015-12-10 22:32:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513873002/20001
5 years ago (2015-12-10 22:38:24 UTC) #6
Dan Ehrenberg
On 2015/12/10 at 22:32:54, adamk wrote: > lgtm % es_staging/harmony confusion > > https://codereview.chromium.org/1513873002/diff/1/src/flag-definitions.h > ...
5 years ago (2015-12-10 22:43:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/11289)
5 years ago (2015-12-10 22:53:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513873002/40001
5 years ago (2015-12-10 23:00:29 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-10 23:57:45 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-10 23:58:39 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/88c8361b8fd11566983e6ae071e74770b5c506ad
Cr-Commit-Position: refs/heads/master@{#32772}

Powered by Google App Engine
This is Rietveld 408576698