Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: src/v8.gyp

Issue 1812673005: Use ICU case conversion/transliterator for case conversion behind a flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Yang's comment addressed - return right away for no-change Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/v8.gyp
diff --git a/src/v8.gyp b/src/v8.gyp
index 25e678080b9db741b65b763dd925756331540db3..c75b9bd1d2d7cc2d9c4d05af56a44275439f7699 100644
--- a/src/v8.gyp
+++ b/src/v8.gyp
@@ -1989,17 +1989,6 @@
}, {
'toolsets': ['target'],
}],
- ['v8_enable_i18n_support==1', {
- 'variables': {
- 'i18n_library_files': [
- 'js/i18n.js',
- ],
- },
- }, {
- 'variables': {
- 'i18n_library_files': [],
- },
- }],
],
'variables': {
'library_files': [
@@ -2049,6 +2038,12 @@
'libraries_experimental_bin_file': '<(SHARED_INTERMEDIATE_DIR)/libraries-experimental.bin',
'libraries_extras_bin_file': '<(SHARED_INTERMEDIATE_DIR)/libraries-extras.bin',
'libraries_experimental_extras_bin_file': '<(SHARED_INTERMEDIATE_DIR)/libraries-experimental-extras.bin',
+ 'conditions': [
+ ['v8_enable_i18n_support==1', {
+ 'library_files': ['js/i18n.js'],
+ 'experimental_library_files': ['js/icu-case-mapping.js'],
+ }],
+ ],
},
'actions': [
{
@@ -2056,7 +2051,6 @@
'inputs': [
'../tools/js2c.py',
'<@(library_files)',
- '<@(i18n_library_files)'
],
'outputs': ['<(SHARED_INTERMEDIATE_DIR)/libraries.cc'],
'action': [
@@ -2065,7 +2059,6 @@
'<(SHARED_INTERMEDIATE_DIR)/libraries.cc',
'CORE',
'<@(library_files)',
- '<@(i18n_library_files)'
],
},
{
@@ -2073,7 +2066,6 @@
'inputs': [
'../tools/js2c.py',
'<@(library_files)',
- '<@(i18n_library_files)'
],
'outputs': ['<@(libraries_bin_file)'],
'action': [
@@ -2082,7 +2074,6 @@
'<(SHARED_INTERMEDIATE_DIR)/libraries.cc',
'CORE',
'<@(library_files)',
- '<@(i18n_library_files)',
'--startup_blob', '<@(libraries_bin_file)',
'--nojs',
],
@@ -2099,7 +2090,7 @@
'../tools/js2c.py',
'<(SHARED_INTERMEDIATE_DIR)/experimental-libraries.cc',
'EXPERIMENTAL',
- '<@(experimental_library_files)'
+ '<@(experimental_library_files)',
],
},
{

Powered by Google App Engine
This is Rietveld 408576698