src/runtime/runtime-strings.cc - Issue 1812673005: Use ICU case conversion/transliterator for case conversion behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-strings.cc

Issue 1812673005: Use ICU case conversion/transliterator for case conversion behind a flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Yang's comment addressed - return right away for no-change Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-strings.cc

diff --git a/src/runtime/runtime-strings.cc b/src/runtime/runtime-strings.cc

index 71f27a03d6edaf487efc206f11a8fca9eb76959a..2477eb70b9026a5256563b19c9bed124643a44c8 100644

--- a/src/runtime/runtime-strings.cc

+++ b/src/runtime/runtime-strings.cc

@@ -1077,7 +1077,7 @@ MUST_USE_RESULT static Object* ConvertCase(

RUNTIME_FUNCTION(Runtime_StringToLowerCase) {

HandleScope scope(isolate);

- DCHECK(args.length() == 1);

+ DCHECK_EQ(args.length(), 1);

CONVERT_ARG_HANDLE_CHECKED(String, s, 0);

return ConvertCase(s, isolate, isolate->runtime_state()->to_lower_mapping());

}

@@ -1085,7 +1085,7 @@ RUNTIME_FUNCTION(Runtime_StringToLowerCase) {

RUNTIME_FUNCTION(Runtime_StringToUpperCase) {

HandleScope scope(isolate);

- DCHECK(args.length() == 1);

+ DCHECK_EQ(args.length(), 1);

CONVERT_ARG_HANDLE_CHECKED(String, s, 0);

return ConvertCase(s, isolate, isolate->runtime_state()->to_upper_mapping());

}

« src/runtime/runtime-i18n.cc ('K') | « src/runtime/runtime-i18n.cc ('k') | src/v8.gyp » ('j') | no next file with comments »