Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: src/flag-definitions.h

Issue 1812673005: Use ICU case conversion/transliterator for case conversion behind a flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address Yang's comment. the feature is now harmony_in_progress instead of harmony_staged Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/js/i18n.js » ('j') | src/js/i18n.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index 641423bb4e84de62d559aa2d105dcd8302103401..c456c7210168e0ee20d258f5fa669537aab774ff 100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -193,6 +193,16 @@ DEFINE_IMPLICATION(es_staging, harmony_regexp_lookbehind)
DEFINE_IMPLICATION(es_staging, move_object_start)
// Features that are still work in progress (behind individual flags).
+#ifdef V8_I18N_SUPPORT
+#define HARMONY_INPROGRESS(V) \
+ V(harmony_explicit_tailcalls, "harmony explicit tail calls") \
+ V(harmony_function_sent, "harmony function.sent") \
+ V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \
+ V(harmony_simd, "harmony simd") \
+ V(harmony_do_expressions, "harmony do-expressions") \
+ V(harmony_regexp_property, "harmony unicode regexp property classes") \
+ V(icu_case_mapping, "case mapping with ICU rather than Unibrow")
+#else
Dan Ehrenberg 2016/05/10 19:29:37 Could you define this flag unconditionally, and ig
jungshik at Google 2016/05/10 23:22:33 HARMONY_INPROGRESS() macro is used in a few places
#define HARMONY_INPROGRESS(V) \
V(harmony_explicit_tailcalls, "harmony explicit tail calls") \
V(harmony_function_sent, "harmony function.sent") \
@@ -200,6 +210,7 @@ DEFINE_IMPLICATION(es_staging, move_object_start)
V(harmony_simd, "harmony simd") \
V(harmony_do_expressions, "harmony do-expressions") \
V(harmony_regexp_property, "harmony unicode regexp property classes")
+#endif
// Features that are complete (but still behind --harmony/es-staging flag).
#define HARMONY_STAGED(V) \
« no previous file with comments | « src/bootstrapper.cc ('k') | src/js/i18n.js » ('j') | src/js/i18n.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698