Use ICU case conversion/transliterator for case conversion behind a flag

src/flag-definitions.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines all of the flags.  It is separated into different section,
 // for Debug, Release, Logging and Profiling, etc.  To add a new flag, find the
 // correct section, and use one of the DEFINE_ macros, without a trailing ';'.
 //
 // This include does not have a guard, because it is a template-style include,
 // which can be included multiple times in different modes.  It expects to have
@@ skipping 175 matching lines @@
 
 DEFINE_BOOL(promise_extra, true, "additional V8 Promise functions")
 // Removing extra Promise functions is staged
 DEFINE_NEG_IMPLICATION(harmony, promise_extra)
 
 // Activate on ClusterFuzz.
 DEFINE_IMPLICATION(es_staging, harmony_regexp_lookbehind)
 DEFINE_IMPLICATION(es_staging, move_object_start)
 
 // Features that are still work in progress (behind individual flags).
+#ifdef V8_I18N_SUPPORT
+#define HARMONY_INPROGRESS(V)                                           \
+  V(harmony_explicit_tailcalls, "harmony explicit tail calls")          \
+  V(harmony_function_sent, "harmony function.sent")                     \
+  V(harmony_sharedarraybuffer, "harmony sharedarraybuffer")             \
+  V(harmony_simd, "harmony simd")                                       \
+  V(harmony_do_expressions, "harmony do-expressions")                   \
+  V(harmony_regexp_property, "harmony unicode regexp property classes") \
+  V(icu_case_mapping, "case mapping with ICU rather than Unibrow")
+#else

[Dan Ehrenberg, 2016/05/10 19:29:37]

Could you define this flag unconditionally, and ignore it when ICU is not
present?

[jungshik at Google, 2016/05/10 23:22:33]

HARMONY_INPROGRESS() macro is used in a few places in bootstrap.cc. They pull in
icu-case-mapping.js, the js file is NOT bundled in a build when i18n support is
disabled. So, I guess we have to do this way even though it's ugly. 

 #define HARMONY_INPROGRESS(V)                                  \
   V(harmony_explicit_tailcalls, "harmony explicit tail calls") \
   V(harmony_function_sent, "harmony function.sent")            \
   V(harmony_sharedarraybuffer, "harmony sharedarraybuffer")    \
   V(harmony_simd, "harmony simd")                              \
   V(harmony_do_expressions, "harmony do-expressions")          \
   V(harmony_regexp_property, "harmony unicode regexp property classes")
+#endif
 
 // Features that are complete (but still behind --harmony/es-staging flag).
 #define HARMONY_STAGED(V)                                                    \
   V(harmony_regexp_lookbehind, "harmony regexp lookbehind")                  \
   V(harmony_tailcalls, "harmony tail calls")                                 \
   V(harmony_object_values_entries, "harmony Object.values / Object.entries") \
   V(harmony_object_own_property_descriptors,                                 \
     "harmony Object.getOwnPropertyDescriptors()")                            \
   V(harmony_string_padding, "harmony String-padding methods")
 
@@ skipping 958 matching lines @@
 #undef DEFINE_ALIAS_FLOAT
 #undef DEFINE_ALIAS_ARGS
 
 #undef FLAG_MODE_DECLARE
 #undef FLAG_MODE_DEFINE
 #undef FLAG_MODE_DEFINE_DEFAULTS
 #undef FLAG_MODE_META
 #undef FLAG_MODE_DEFINE_IMPLICATIONS
 
 #undef COMMA