Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1812473002: PPC: [wasm] Int64Lowering of Int64Sub. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [wasm] Int64Lowering of Int64Sub. Port 33c08596e10f8ed64f8097049ac6c424c0616ee1 Original commit message: Int64Sub is lowered to a new turbofan operator, Int32SubPair. The new operator takes 4 inputs an generates 2 outputs. The inputs are the low word of the left input, high word of the left input, the low word of the right input, and high word of the right input. The ouputs are the low and high word of the result of the subtraction. The implementation is very similar to the implementation of Int64Add. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/eb0a2324a1689f8eea35c2f2efc5d503e60062e3 Cr-Commit-Position: refs/heads/master@{#34821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -17 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-scheduler-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M src/ppc/assembler-ppc.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/ppc/disasm-ppc.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 1 chunk +23 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
MTBrandyberry
PTAL. Needs owner approval for cctest change.
4 years, 9 months ago (2016-03-16 14:29:53 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812473002/1
4 years, 9 months ago (2016-03-16 14:30:07 UTC) #5
titzer
On 2016/03/16 14:30:07, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 9 months ago (2016-03-16 14:31:07 UTC) #6
michael_dawson
On 2016/03/16 14:31:07, titzer wrote: > On 2016/03/16 14:30:07, commit-bot: I haz the power wrote: ...
4 years, 9 months ago (2016-03-16 14:45:42 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 14:49:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812473002/1
4 years, 9 months ago (2016-03-16 15:14:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 15:26:02 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 15:26:32 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb0a2324a1689f8eea35c2f2efc5d503e60062e3
Cr-Commit-Position: refs/heads/master@{#34821}

Powered by Google App Engine
This is Rietveld 408576698