Issue 181233006: RendererWebColorChooserImpl shouldn't be destroyed by RenderViewObserver::OnDestruct

Issue 181233006: RendererWebColorChooserImpl shouldn't be destroyed by RenderViewObserver::OnDestruct (Closed)

Created:
6 years, 9 months ago by keishi

Modified:
6 years, 9 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

RendererWebColorChooserImpl shouldn't be destroyed by RenderViewObserver::OnDestruct RenderWebColorChooserImpl is owned by blink::ColorChooserUIController so it should not be destroyed in RenderViewObserver::OnDestruct BUG=342735 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255276

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	content/renderer/renderer_webcolorchooser_impl.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/181233006/1

6 years, 9 months ago (2014-03-05 22:50:52 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/181233006/1

6 years, 9 months ago (2014-03-06 00:08:34 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/181233006/1

6 years, 9 months ago (2014-03-06 02:51:07 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/181233006/1

6 years, 9 months ago (2014-03-06 03:15:39 UTC) #7

Message was sent while issue was closed.

Change committed as 255276

Expand Messages | Collapse Messages