Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: content/shell/renderer/webkit_test_runner.cc

Issue 18123002: Migrate webkit/renderer/media/ to content/renderer/media/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase on mo time Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/webkit_test_runner.cc
diff --git a/content/shell/renderer/webkit_test_runner.cc b/content/shell/renderer/webkit_test_runner.cc
index 94b5619287a02f33717c1accb01e0d06c6a747cc..49f3f187be5e3045d41d16d53baa4de5e2213c8f 100644
--- a/content/shell/renderer/webkit_test_runner.cc
+++ b/content/shell/renderer/webkit_test_runner.cc
@@ -515,9 +515,12 @@ void WebKitTestRunner::captureHistoryForWindow(
history->swap(result);
}
+// TODO(scherkus): Remove once https://codereview.chromium.org/18130006
+// rolls into Chromium.
WebMediaPlayer* WebKitTestRunner::createWebMediaPlayer(
- WebFrame* frame, const WebURL& url, WebMediaPlayerClient* client)
-{
+ WebFrame* frame,
+ const WebURL& url,
+ WebMediaPlayerClient* client) {
if (!shell_media_stream_client_) {
shell_media_stream_client_.reset(new ShellMediaStreamClient());
}
@@ -534,10 +537,12 @@ WebMediaPlayer* WebKitTestRunner::createWebMediaPlayer(
#if defined(OS_ANDROID)
return NULL;
#else
- // TODO(scherkus): Use RenderViewImpl::createMediaPlayer() instead of
- // duplicating code here, see http://crbug.com/239826
webkit_media::WebMediaPlayerParams params(
- GetMediaThreadMessageLoopProxy(), NULL, NULL, new media::MediaLog());
+ GetMediaThreadMessageLoopProxy(),
+ base::Callback<void(const base::Closure&)>(),
+ NULL,
+ NULL,
+ new media::MediaLog());
return new webkit_media::WebMediaPlayerImpl(
frame,
client,

Powered by Google App Engine
This is Rietveld 408576698