Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1825)

Unified Diff: content/renderer/render_view_impl.cc

Issue 18123002: Migrate webkit/renderer/media/ to content/renderer/media/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase on mo time Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 7bcff2120e2e9fc8ea8ec348cde5ce26f961fc4f..54e4e4c682313bafdfc285e4dbe57d29e63f864e 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2852,7 +2852,14 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(
const CommandLine* cmd_line = CommandLine::ForCurrentProcess();
#if defined(ENABLE_WEBRTC) && !defined(GOOGLE_TV)
- if (MediaStreamImpl::CheckMediaStream(url)) {
+ webkit_media::MediaStreamClient* media_stream_client =
+ GetContentClient()->renderer()->OverrideCreateMediaStreamClient();
+ if (!media_stream_client) {
+ EnsureMediaStreamImpl();
+ media_stream_client = media_stream_impl_;
+ }
+
+ if (media_stream_client->IsMediaStream(url)) {
#if defined(OS_ANDROID) && defined(ARCH_CPU_ARMEL)
bool found_neon =
(android_getCpuFeatures() & ANDROID_CPU_ARM_FEATURE_NEON) != 0;
@@ -2860,7 +2867,7 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(
#endif // defined(OS_ANDROID) && defined(ARCH_CPU_ARMEL)
EnsureMediaStreamImpl();
ycheo (away) 2013/07/03 02:41:04 QQ) Is this needed? If it is, should we use 'media
scherkus (not reviewing) 2013/07/03 20:10:30 no it is no longer needed
return new webkit_media::WebMediaPlayerMS(
- frame, client, AsWeakPtr(), media_stream_impl_, new RenderMediaLog());
+ frame, client, AsWeakPtr(), media_stream_client, new RenderMediaLog());
}
#endif
@@ -2940,15 +2947,14 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(
webkit_media::WebMediaPlayerParams params(
RenderThreadImpl::current()->GetMediaThreadMessageLoopProxy(),
- sink, gpu_factories, new RenderMediaLog());
- WebMediaPlayer* media_player =
- GetContentClient()->renderer()->OverrideCreateWebMediaPlayer(
- this, frame, client, AsWeakPtr(), params);
- if (!media_player) {
- media_player = new webkit_media::WebMediaPlayerImpl(
- frame, client, AsWeakPtr(), params);
- }
- return media_player;
+ base::Bind(&ContentRendererClient::DeferMediaLoad,
+ base::Unretained(GetContentClient()->renderer()),
+ static_cast<RenderView*>(this)),
+ sink,
+ gpu_factories,
+ new RenderMediaLog());
+ return new webkit_media::WebMediaPlayerImpl(
+ frame, client, AsWeakPtr(), params);
}
WebApplicationCacheHost* RenderViewImpl::createApplicationCacheHost(

Powered by Google App Engine
This is Rietveld 408576698