Chromium Code Reviews| Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java |
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderItemViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java |
| similarity index 54% |
| rename from chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderItemViewHolder.java |
| rename to chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java |
| index 05eda5aad16868f435b934728e4db5d06ae2ddba..aab8c00a254cf631da065c1587a0dd58778202c9 100644 |
| --- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderItemViewHolder.java |
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetHeaderViewHolder.java |
| @@ -7,21 +7,17 @@ package org.chromium.chrome.browser.ntp.snippets; |
| import android.view.LayoutInflater; |
| import android.view.View; |
| import android.view.ViewGroup; |
| -import android.widget.TextView; |
| import org.chromium.chrome.R; |
| -import org.chromium.chrome.browser.ntp.snippets.SnippetsManager.SnippetHeader; |
| -import org.chromium.chrome.browser.ntp.snippets.SnippetsManager.SnippetListItem; |
| +import org.chromium.chrome.browser.ntp.NewTabPageCardsManager.NewTabPageListItem; |
| +import org.chromium.chrome.browser.ntp.NewTabPageViewHolder; |
| /** |
| * A class that represents the view for a header of a group of card snippets. |
| */ |
| -class SnippetHeaderItemViewHolder extends SnippetListItemViewHolder { |
| - private TextView mHeaderTextView; |
| - |
| - public SnippetHeaderItemViewHolder(View view, SnippetsManager manager) { |
| +public class SnippetHeaderViewHolder extends NewTabPageViewHolder { |
| + public SnippetHeaderViewHolder(View view, SnippetsManager manager) { |
| super(view, manager); |
| - mHeaderTextView = (TextView) view.findViewById(R.id.snippets_list_header); |
| } |
| /** |
| @@ -36,11 +32,5 @@ class SnippetHeaderItemViewHolder extends SnippetListItemViewHolder { |
| } |
| @Override |
| - public void onBindViewHolder(SnippetListItem snippetItem) { |
| - SnippetHeader item = (SnippetHeader) snippetItem; |
| - |
| - String headerText = mHeaderTextView.getContext().getString( |
| - R.string.snippets_header, item.mRecommendationBasis); |
| - mHeaderTextView.setText(headerText); |
| - } |
| + public void onBindViewHolder(NewTabPageListItem snippetItem) {} |
|
newt (away)
2016/03/24 19:47:39
why are we no longer setting the header text here?
dgn
2016/03/28 21:33:02
The string is now directly provided in new_tab_pag
|
| } |